Skip to content

[FEA] Relax requirements for versions.json git_url / git_tag for proprietary binaries #702

Open
@bdice

Description

@bdice

Is your feature request related to a problem? Please describe.
cuDF has not supported nvcomp 2.2.0 for a long time, but rapids-cmake's versions.json still has an entry for nvcomp 2.2.0 and the outdated repo page (the nvcomp repo states, "This page will be retired soon" so the git_url will soon be irrelevant). However, we can't remove this outdated information because the versions.json parser expects git_url and git_tag to exist.

Describe the solution you'd like
Update the parser so that proprietary packages can be used with only proprietary_binary information, without specifying git_url and git_tag.

Describe alternatives you've considered
One alternative would be to allow an empty string like "git_url": "" / "git_tag": "", but that also fails with rapids_cmake can't parse 'nvcomp' json entry, it is missing a `git_url` entry.

Additional context
Related to rapidsai/cudf#16757.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions