Skip to content

[FEA] Set -ffile_prefix_map when in a conda-build #798

Closed
@vyasr

Description

@vyasr

Is your feature request related to a problem? Please describe.
The issue that we would like to resolve is documented in rapidsai/build-planning#159.

Describe the solution you'd like
rapids-cmake's rapids_cmake_support_conda_env contains various bits of logic specialized to conda environments, and further, to building inside conda-build. Based on the discussions in rapidsai/build-planning#159, we should consider augmenting this feature to also remap the file prefix. This ensures that we do not embed non-relocatable paths into our binaries via the usage of the __FILE__ macro. We could inject this logic into the conda-build-specific sections of rapids_cmake_support_conda_env.

As long as we are fine with using the root of the C++ CMakeLists.txt as the new prefix, this should be straightforward. Things will get a bit hairier if we want to remap the base prefix to be something like the root of the repository (as demonstrated in rapidsai/rmm#1861) since that is a directory above the build, but it should still be possible

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions