Commit ef891a1
authored
Change get_gtest to link statically and remove tests from package (#261)
Currently, the `librapidsmpf` packages ship gtest/gmock library and include files, which they shouldn't.
Simplifying this down to the current version also in libcudf should fix that (i.e. by linking statically).
I would just do this to keep similar to stay similar to other rapids libraries, unless this is somehow different?
~(I think there is another small issue with `mpi_tests` and `ucxx_tests` getting shipped in `librapidsmpf` rather than `librapidsmpf-tests`, but I'll have a look at it seperately.)~
Authors:
- Sebastian Berg (https://github.com/seberg)
Approvers:
- Mads R. B. Kristensen (https://github.com/madsbk)
- Peter Andreas Entschev (https://github.com/pentschev)
- Gil Forsyth (https://github.com/gforsyth)
URL: #2611 parent 6877cb6 commit ef891a1
4 files changed
Lines changed: 6 additions & 20 deletions
File tree
- cmake/thirdparty
- conda/recipes/librapidsmpf
- cpp
- benchmarks
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 11 | + | |
29 | 12 | | |
30 | 13 | | |
31 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| 141 | + | |
141 | 142 | | |
142 | 143 | | |
143 | 144 | | |
144 | 145 | | |
145 | 146 | | |
146 | 147 | | |
147 | 148 | | |
| 149 | + | |
148 | 150 | | |
0 commit comments