Skip to content

Commit 1ab4920

Browse files
authored
Avoid --find-links in wheel jobs (#1586)
Contributes to rapidsai/build-planning#69. Proposes a stricter pattern for passing a `librmm` wheel from the `wheel-build-cpp` job that produced it into the `wheel-build-python` job wanting to use it (as a build dependency of `rmm`). This change improves the likelihood that issues with the `librmm` wheels will be caught in CI. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1586
1 parent f2d0797 commit 1ab4920

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

ci/build_wheel_python.sh

+8-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,14 @@ cd "${package_dir}"
1616
RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"
1717
CPP_WHEELHOUSE=$(RAPIDS_PY_WHEEL_NAME="rmm_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 cpp /tmp/librmm_dist)
1818

19-
python -m pip wheel . -w dist -vvv --no-deps --disable-pip-version-check --find-links "${CPP_WHEELHOUSE}"
19+
# ensure 'rmm' wheel builds always use the 'librmm' just built in the same CI run
20+
#
21+
# using env variable PIP_CONSTRAINT is necessary to ensure the constraints
22+
# are used when created the isolated build environment
23+
echo "librmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${CPP_WHEELHOUSE}/librmm_${RAPIDS_PY_CUDA_SUFFIX}*.whl)" > ./build-constraints.txt
24+
25+
PIP_CONSTRAINT="${PWD}/build-constraints.txt" \
26+
python -m pip wheel . -w dist -vvv --no-deps --disable-pip-version-check
2027

2128
mkdir -p final_dist
2229
python -m auditwheel repair -w final_dist dist/*

0 commit comments

Comments
 (0)