test: fix nginx temp path for non-root user

Under some unknown circumstances, the current nginx config run as
non-root still leads to fatal errors:

    $ ./test/wait-for-hawkbit-online && dbus-run-session -- pytest -v -o log_cli=true test/test_download.py
    [...]
    test/test_download.py::test_download_too_slow
    -------------------------------------------------------- live log call --------------------------------------------------------
    INFO nginx running: nginx -c /tmp/pytest-of-thibaud/pytest-8/nginx0/nginx.conf -p .
    INFO nginx nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (13: Permission denied)
    INFO nginx 2024/06/28 15:41:56 [emerg] 1450257#1450257: mkdir() "/var/lib/nginx/tmp/client_body" failed (13: Permission denied)
    SKIPPED (nginx failed, use -s to see logs)                                                                              [ 42%]
    test/test_download.py::test_download_partials_without_resume
    ------------------------------------------------------- live log setup --------------------------------------------------------
    INFO nginx running: nginx -c /tmp/pytest-of-thibaud/pytest-8/nginx1/nginx.conf -p .
    INFO nginx nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (13: Permission denied)
    INFO nginx 2024/06/28 15:41:56 [emerg] 1450258#1450258: mkdir() "/var/lib/nginx/tmp/client_body" failed (13: Permission denied)
    SKIPPED (nginx failed, use -s to see logs)                                                                              [ 57%]
    test/test_download.py::test_download_partials_with_resume SKIPPED (nginx failed, use -s to see logs)                    [ 71%]
    test/test_download.py::test_download_slow_with_resume
    -------------------------------------------------------- live log call --------------------------------------------------------
    INFO nginx running: nginx -c /tmp/pytest-of-thibaud/pytest-8/nginx2/nginx.conf -p .
    INFO nginx nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (13: Permission denied)
    INFO nginx 2024/06/28 15:41:56 [emerg] 1450259#1450259: mkdir() "/var/lib/nginx/tmp/client_body" failed (13: Permission denied)
    SKIPPED (nginx failed, use -s to see logs)

The section "Running nginx as a non-root user" of the official nginx
docker image [1] gives a hint what options must be set to not run into
errors. Apply the config directives appropriate for our use case.

[1] https://hub.docker.com/_/nginx

Signed-off-by: Thibaud Dufour <[email protected]>
[bst: dropped unused options fastcgi_temp_path, uwsgi_temp_path, scgi_temp_path, rebased]
Signed-off-by: Bastian Krause <[email protected]>

Author: tduf

test/conftest.py

@@ -1,3 +1,4 @@
+
 # SPDX-License-Identifier: LGPL-2.1-only
 # SPDX-FileCopyrightText: 2021 Enrico Jörns <[email protected]>, Pengutronix
 # SPDX-FileCopyrightText: 2021-2022 Bastian Krause <[email protected]>, Pengutronix
@@ -259,6 +260,7 @@ def _nginx_config(port, location_options, *, mtls=False):
             location_options=_to_nginx_option(location_options),
             server_options=_to_nginx_option(server_options),
             module_path=os.environ.get('NGINX_MODULES', '/usr/lib/nginx/modules'),
+            nginx_temp=nginx_temp,
         )
         proxy_config.write_text(proxy_config_str)
 

test/nginx/base.conf.in

@@ -12,6 +12,8 @@ events { }
 
 http {
     access_log /dev/null;
+    client_body_temp_path /${nginx_temp}/client_temp;
+    proxy_temp_path       /${nginx_temp}/proxy_temp_path;
 
     map $$ssl_client_s_dn $$ssl_client_s_dn_cn {
         default "";