Skip to content

Commit 14e806b

Browse files
authored
Add logging (project-chip#42921)
1 parent c2d5934 commit 14e806b

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/app/clusters/groups-server/GroupsCluster.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ bool emberAfGroupsClusterRemoveAllGroupsCallback(app::CommandHandler * commandOb
341341
}
342342
#endif
343343

344-
TEMPORARY_RETURN_IGNORED provider->RemoveEndpoint(fabricIndex, commandPath.mEndpointId);
344+
LogErrorOnFailure(provider->RemoveEndpoint(fabricIndex, commandPath.mEndpointId));
345345
status = Status::Success;
346346
MatterReportingAttributeChangeCallback(kRootEndpointId, GroupKeyManagement::Id, GroupKeyManagement::Attributes::GroupTable::Id);
347347
exit:

src/app/clusters/scenes-server/CodegenIntegration.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -167,43 +167,43 @@ void ScenesServer::GroupWillBeRemoved(FabricIndex aFabricIx, EndpointId aEndpoin
167167
ScenesManagementCluster * cluster = FindClusterOnEndpoint(aEndpointId);
168168
VerifyOrReturn(cluster != nullptr);
169169

170-
TEMPORARY_RETURN_IGNORED cluster->GroupWillBeRemoved(aFabricIx, aGroupId);
170+
LogErrorOnFailure(cluster->GroupWillBeRemoved(aFabricIx, aGroupId));
171171
}
172172

173173
void ScenesServer::MakeSceneInvalid(EndpointId aEndpointId, FabricIndex aFabricIx)
174174
{
175175
ScenesManagementCluster * cluster = FindClusterOnEndpoint(aEndpointId);
176176
VerifyOrReturn(cluster != nullptr);
177177

178-
TEMPORARY_RETURN_IGNORED cluster->MakeSceneInvalid(aFabricIx);
178+
LogErrorOnFailure(cluster->MakeSceneInvalid(aFabricIx));
179179
}
180180

181181
void ScenesServer::MakeSceneInvalidForAllFabrics(EndpointId aEndpointId)
182182
{
183183
ScenesManagementCluster * cluster = FindClusterOnEndpoint(aEndpointId);
184184
VerifyOrReturn(cluster != nullptr);
185-
TEMPORARY_RETURN_IGNORED cluster->MakeSceneInvalidForAllFabrics();
185+
LogErrorOnFailure(cluster->MakeSceneInvalidForAllFabrics());
186186
}
187187

188188
void ScenesServer::StoreCurrentScene(FabricIndex aFabricIx, EndpointId aEndpointId, GroupId aGroupId, SceneId aSceneId)
189189
{
190190
ScenesManagementCluster * cluster = FindClusterOnEndpoint(aEndpointId);
191191
VerifyOrReturn(cluster != nullptr);
192-
TEMPORARY_RETURN_IGNORED cluster->StoreCurrentScene(aFabricIx, aGroupId, aSceneId);
192+
LogErrorOnFailure(cluster->StoreCurrentScene(aFabricIx, aGroupId, aSceneId));
193193
}
194194

195195
void ScenesServer::RecallScene(FabricIndex aFabricIx, EndpointId aEndpointId, GroupId aGroupId, SceneId aSceneId)
196196
{
197197
ScenesManagementCluster * cluster = FindClusterOnEndpoint(aEndpointId);
198198
VerifyOrReturn(cluster != nullptr);
199-
TEMPORARY_RETURN_IGNORED cluster->RecallScene(aFabricIx, aGroupId, aSceneId);
199+
LogErrorOnFailure(cluster->RecallScene(aFabricIx, aGroupId, aSceneId));
200200
}
201201

202202
void ScenesServer::RemoveFabric(EndpointId aEndpointId, FabricIndex aFabricIndex)
203203
{
204204
ScenesManagementCluster * cluster = FindClusterOnEndpoint(aEndpointId);
205205
VerifyOrReturn(cluster != nullptr);
206-
TEMPORARY_RETURN_IGNORED cluster->RemoveFabric(aFabricIndex);
206+
LogErrorOnFailure(cluster->RemoveFabric(aFabricIndex));
207207
}
208208

209209
} // namespace chip::app::Clusters::ScenesManagement

0 commit comments

Comments
 (0)