Make template source files match output names in a consistent manner (project-chip#38886)

* Update file names in sdk generator and templates.json

- Renamed files ending in '-src.zapt' to now end with either '.ipp.zapt' or '.cpp.zapt'
- Renamed files that created .h files, and/or had names ending in '-header.zapt' to now end in '.h.zapt'
- Renamed jinja files referenced in sdk_generator.py to end in '.h.ninja'.
- Renamed ClusterMetadataHeader.jinja to Metada.h.jinja

* Update file names for all effected zap template files and .jinja files

* Codegen from zap and jinja

* Update files.gni with new jinja file names

* Fix file name and the reference to specific cluster enums zapt file for templates.json

* Zap regen

* New line formatting issue

* Fix lint error based on grep of file name

* Add comments linking generated files to their zapt counterparts

* zap regen

* Change naming based on pr comments

* Zap regen

* Zap regen

* Change naming case based on comment

* Zap regen

---------

Co-authored-by: Andrei Litvin <andy314@gmail.com>

Author: zaid-google

.github/workflows/lint.yml

@@ -274,7 +274,7 @@ jobs:
                   type-safe getters
               if: always()
               run: |
-                  git grep -I -n 'emberAfReadAttribute' -- './*' ':(exclude).github/workflows/lint.yml' ':(exclude)src/app/util/attribute-table.h' ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt' ':(exclude)src/app/util/attribute-table.cpp'  && exit 1 || exit 0
+                  git grep -I -n 'emberAfReadAttribute' -- './*' ':(exclude).github/workflows/lint.yml' ':(exclude)src/app/util/attribute-table.h' ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors.cpp.zapt' ':(exclude)src/app/util/attribute-table.cpp'  && exit 1 || exit 0
 
             # git grep exits with 0 if it finds a match, but we want
             # to fail (exit nonzero) on match.  And we want to exclude this file,
@@ -295,7 +295,7 @@ jobs:
                       ':(exclude)src/app/util/attribute-table.cpp'                                           \
                       ':(exclude)src/app/util/attribute-table.h'                                             \
                       ':(exclude)src/app/util/mock/CodegenEmberMocks.cpp'                                    \
-                      ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt'          \
+                      ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors.cpp.zapt'          \
                       ':(exclude)src/darwin/Framework/CHIP/ServerEndpoint/MTRIMDispatch.mm'                  \
                       ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' \
                       && exit 1 || exit 0

scripts/py_matter_idl/files.gni

@@ -8,13 +8,13 @@ matter_idl_generator_templates = [
   "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/application/PluginApplicationCallbacksHeader.jinja",
   "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/application/ServerClusterConfig.jinja",
   "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/AllItemsBuild.jinja",
-  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/AttributeIds.jinja",
+  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/AttributeIds.h.jinja",
   "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/Build.jinja",
-  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/ClusterId.jinja",
-  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/ClusterMetadataHeader.jinja",
-  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/CommandIds.jinja",
-  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/EventIds.jinja",
-  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/Ids.jinja",
+  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/ClusterId.h.jinja",
+  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/Metadata.h.jinja",
+  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/CommandIds.h.jinja",
+  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/EventIds.h.jinja",
+  "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/sdk/Ids.h.jinja",
   "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/tlvmeta/TLVMetaData_cpp.jinja",
   "${chip_root}/scripts/py_matter_idl/matter/idl/generators/cpp/tlvmeta/TLVMetaData_h.jinja",
   "${chip_root}/scripts/py_matter_idl/matter/idl/generators/idl/MatterIdl.jinja",

…dl/generators/cpp/sdk/AttributeIds.jinja …/generators/cpp/sdk/AttributeIds.h.jinjascripts/py_matter_idl/matter/idl/generators/cpp/sdk/AttributeIds.jinja renamed to scripts/py_matter_idl/matter/idl/generators/cpp/sdk/AttributeIds.h.jinja scripts/py_matter_idl/matter/idl/generators/cpp/sdk/AttributeIds.jinja renamed to scripts/py_matter_idl/matter/idl/generators/cpp/sdk/AttributeIds.h.jinja

@@ -123,14 +123,14 @@ def internal_render_all(self):
                 "Build.jinja": "BUILD.gn",
 
                 # contains `*Entry` items for attributes and commands
-                "ClusterMetadataHeader.jinja": "Metadata.h",
+                "Metadata.h.jinja": "Metadata.h",
 
                 # contains id definitions
-                "AttributeIds.jinja": "AttributeIds.h",
-                "ClusterId.jinja": "ClusterId.h",
-                "CommandIds.jinja": "CommandIds.h",
-                "EventIds.jinja": "EventIds.h",
-                "Ids.jinja": "Ids.h",
+                "AttributeIds.h.jinja": "AttributeIds.h",
+                "ClusterId.h.jinja": "ClusterId.h",
+                "CommandIds.h.jinja": "CommandIds.h",
+                "EventIds.h.jinja": "EventIds.h",
+                "Ids.h.jinja": "Ids.h",
             }
 
             for template_path, output_file in build_targets.items():

…r/idl/generators/cpp/sdk/ClusterId.jinja …idl/generators/cpp/sdk/ClusterId.h.jinjascripts/py_matter_idl/matter/idl/generators/cpp/sdk/ClusterId.jinja renamed to scripts/py_matter_idl/matter/idl/generators/cpp/sdk/ClusterId.h.jinja scripts/py_matter_idl/matter/idl/generators/cpp/sdk/ClusterId.jinja renamed to scripts/py_matter_idl/matter/idl/generators/cpp/sdk/ClusterId.h.jinja

@@ -40,146 +40,146 @@
     ],
     "templates": [
         {
-            "path": "../../zap-templates/templates/app/attribute-type.zapt",
+            "path": "../../zap-templates/templates/app/attribute-type.h.zapt",
             "name": "ZCL attribute-type header",
             "output": "attribute-type.h"
         },
         {
-            "path": "../../zap-templates/templates/app/callback.zapt",
+            "path": "../../zap-templates/templates/app/callback.h.zapt",
             "name": "ZCL callback header",
             "output": "callback.h"
         },
         {
-            "path": "../../zap-templates/templates/app/attributes/Accessors.zapt",
+            "path": "../../zap-templates/templates/app/attributes/Accessors.h.zapt",
             "name": "Attributes Accessors header",
             "output": "attributes/Accessors.h"
         },
         {
-            "path": "../../zap-templates/templates/app/attributes/Accessors-src.zapt",
+            "path": "../../zap-templates/templates/app/attributes/Accessors.cpp.zapt",
             "name": "Attributes Accessors",
             "output": "attributes/Accessors.cpp"
         },
         {
-            "path": "../../zap-templates/templates/app/ids/Attributes.zapt",
+            "path": "../../zap-templates/templates/app/ids/Attributes.h.zapt",
             "name": "Attributes Ids header",
             "output": "ids/Attributes.h"
         },
         {
-            "path": "../../zap-templates/templates/app/ids/Clusters.zapt",
+            "path": "../../zap-templates/templates/app/ids/Clusters.h.zapt",
             "name": "Clusters Ids header",
             "output": "ids/Clusters.h"
         },
         {
-            "path": "../../zap-templates/templates/app/ids/Commands.zapt",
+            "path": "../../zap-templates/templates/app/ids/Commands.h.zapt",
             "name": "Commands Ids header",
             "output": "ids/Commands.h"
         },
         {
-            "path": "../../zap-templates/templates/app/ids/Events.zapt",
+            "path": "../../zap-templates/templates/app/ids/Events.h.zapt",
             "name": "Events Ids header",
             "output": "ids/Events.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-objects.zapt",
+            "path": "../../zap-templates/templates/app/cluster-objects.h.zapt",
             "name": "Cluster objects header for Interaction Model",
             "output": "cluster-objects.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-objects-src.zapt",
+            "path": "../../zap-templates/templates/app/cluster-objects.cpp.zapt",
             "name": "Cluster objects source for Interaction Model",
             "output": "cluster-objects.cpp"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-enums.zapt",
+            "path": "../../zap-templates/templates/app/cluster-enums.h.zapt",
             "name": "Enum and bitmap header for clusters",
             "output": "cluster-enums.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-enums-check.zapt",
+            "path": "../../zap-templates/templates/app/cluster-enums-check.h.zapt",
             "name": "Enum and bitmap method check header for clusters",
             "output": "cluster-enums-check.h"
         },
         {
-            "path": "../../zap-templates/templates/app/shared-cluster-enums-header.zapt",
+            "path": "../../zap-templates/templates/app/clusters-shared-Enums.h.zapt",
             "name": "Shared enumerations header",
             "output": "../../clusters/shared/Enums.h"
         },
         {
-            "path": "../../zap-templates/templates/app/shared-cluster-enums-check.zapt",
+            "path": "../../zap-templates/templates/app/clusters-shared-Enums-Check.h.zapt",
             "name": "Shared enumeration check header",
             "output": "../../clusters/shared/EnumsCheck.h"
         },
         {
-            "path": "../../zap-templates/templates/app/shared-cluster-structs.zapt",
+            "path": "../../zap-templates/templates/app/clusters-shared-Structs.h.zapt",
             "name": "Shared/global structures",
             "output": "../../clusters/shared/Structs.h"
         },
         {
-            "path": "../../zap-templates/templates/app/shared-cluster-structs-src.zapt",
+            "path": "../../zap-templates/templates/app/clusters-shared-Structs.ipp.zapt",
             "name": "Shared/global structures",
             "output": "../../clusters/shared/Structs.ipp"
         },
         {
-            "path": "../../zap-templates/templates/app/shared-cluster-attributes.zapt",
+            "path": "../../zap-templates/templates/app/clusters-shared-Attributes.h.zapt",
             "name": "Shared/global structures",
             "output": "../../clusters/shared/Attributes.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-attributes-header.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Attributes.h.zapt",
             "name": "Cluster-specific attribute declarations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Attributes.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-events-header.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Events.h.zapt",
             "name": "Cluster-specific event declarations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Events.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-events-src.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Events.ipp.zapt",
             "name": "Cluster-specific event implementations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Events.ipp"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-structs-header.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Structs.h.zapt",
             "name": "Cluster-specific structure declarations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Structs.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-structs-src.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Structs.ipp.zapt",
             "name": "Cluster-specific structure implementations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Structs.ipp"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-attributes-src.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Attributes.ipp.zapt",
             "name": "Cluster-specific attributes implementations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Attributes.ipp"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-commands-header.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Commands.h.zapt",
             "name": "Cluster-specific command declarations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Commands.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-commands-src.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Commands.ipp.zapt",
             "name": "Cluster-specific command implementations",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Commands.ipp"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-enums-header.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Enums.h.zapt",
             "name": "Cluster-specific enumerations header",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/Enums.h"
         },
         {
-            "path": "../../zap-templates/templates/app/cluster-enums-check-header.zapt",
+            "path": "../../zap-templates/templates/app/clusters-Enums-Check.h.zapt",
             "name": "Cluster-specific enumerations header",
             "iterator": "availableCluster",
             "output": "../../clusters/{name:touppercamelcase}/EnumsCheck.h"