Make TlsClientManagementCommandDelegate persist data (Non-volatile) (project-chip#41383)

* Make TlsClientManagementCommandDelegate persist data (Non-volatile) as required by spec

* Minor fixes to CI

* Unit tests for CertificateTableImpl

* Fix merge conflicts

* Fix CI test failure

* Fix CI test failure

* Fix timeout test failures

* restyle

Author: gmarcosb

examples/all-clusters-app/all-clusters-common/include/tls-client-management-instance.h

@@ -19,13 +19,44 @@
 #pragma once
 
 #include <app/clusters/tls-client-management-server/tls-client-management-server.h>
+#include <app/storage/FabricTableImpl.h>
 #include <app/util/config.h>
 #include <vector>
 
 namespace chip {
 namespace app {
 namespace Clusters {
 
+/// @brief struct used to identify a TLS Endpoint
+inline constexpr uint16_t kUndefinedTlsEndpointId = 0xffff;
+static constexpr uint8_t kMaxProvisionedEndpoints = 254;
+
+struct TlsEndpointId
+{
+    uint16_t mEndpointId = kUndefinedTlsEndpointId;
+
+    TlsEndpointId() = default;
+    TlsEndpointId(uint16_t id) : mEndpointId(id) {}
+
+    uint16_t & Value() { return mEndpointId; }
+    const uint16_t & Value() const { return mEndpointId; }
+
+    void Clear() { mEndpointId = kUndefinedTlsEndpointId; }
+
+    bool IsValid() { return (mEndpointId != kUndefinedTlsEndpointId); }
+
+    bool operator==(const TlsEndpointId & other) const { return (mEndpointId == other.mEndpointId); }
+};
+
+class EndpointTable : public app::Storage::FabricTableImpl<TlsEndpointId, TlsClientManagementDelegate::EndpointStructType>
+{
+public:
+    using Super = app::Storage::FabricTableImpl<TlsEndpointId, TlsClientManagementDelegate::EndpointStructType>;
+
+    EndpointTable() : Super(kMaxProvisionedEndpoints, UINT16_MAX) {}
+    ~EndpointTable() { Finish(); };
+};
+
 /**
  * The application delegate to define the options & implement commands.
  */
@@ -38,24 +69,26 @@ class TlsClientManagementCommandDelegate : public TlsClientManagementDelegate
     };
 
     static TlsClientManagementCommandDelegate instance;
-    std::vector<Provisioned> mProvisioned;
-    uint16_t mNextId = 1;
+    EndpointTable mProvisioned;
+    PersistentStorageDelegate * mStorage = nullptr;
+
+    CHIP_ERROR GetEndpointId(FabricIndex fabric, uint16_t & id);
 
 public:
     TlsClientManagementCommandDelegate() {}
     ~TlsClientManagementCommandDelegate() = default;
 
-    CHIP_ERROR GetProvisionedEndpointByIndex(EndpointId matterEndpoint, FabricIndex fabric, size_t index,
-                                             EndpointStructType & endpoint) const override;
+    CHIP_ERROR Init(PersistentStorageDelegate & storage) override;
+
+    CHIP_ERROR ForEachEndpoint(EndpointId matterEndpoint, FabricIndex fabric, LoadedEndpointCallback callback) override;
 
     Protocols::InteractionModel::ClusterStatusCode
     ProvisionEndpoint(EndpointId matterEndpoint, FabricIndex fabric,
                       const TlsClientManagement::Commands::ProvisionEndpoint::DecodableType & provisionReq,
                       uint16_t & endpointID) override;
 
-    Protocols::InteractionModel::Status FindProvisionedEndpointByID(EndpointId matterEndpoint, FabricIndex fabric,
-                                                                    uint16_t endpointID,
-                                                                    EndpointStructType & endpoint) const override;
+    CHIP_ERROR FindProvisionedEndpointByID(EndpointId matterEndpoint, FabricIndex fabric, uint16_t endpointID,
+                                           LoadedEndpointCallback callback) override;
 
     Protocols::InteractionModel::Status RemoveProvisionedEndpointByID(EndpointId matterEndpoint, FabricIndex fabric,
                                                                       uint16_t endpointID) override;
@@ -65,9 +98,10 @@ class TlsClientManagementCommandDelegate : public TlsClientManagementDelegate
 
     void RemoveFabric(FabricIndex fabric) override;
 
-    static inline TlsClientManagementCommandDelegate & GetInstance() { return instance; }
+    CHIP_ERROR MutateEndpointReferenceCount(EndpointId matterEndpoint, FabricIndex fabric, uint16_t endpointID,
+                                            int8_t delta) override;
 
-    uint16_t GetEndpointId(Provisioned * provisioned);
+    static inline TlsClientManagementCommandDelegate & GetInstance() { return instance; }
 };
 
 } // namespace Clusters