Skip to content

Commit 0847170

Browse files
refactor: Use existing helper to get cluster session key
Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>
1 parent 9210d0d commit 0847170

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

historyserver/pkg/historyserver/router.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -338,17 +338,16 @@ func (s *ServerHandler) getNodes(req *restful.Request, resp *restful.Response) {
338338
return
339339
}
340340

341+
// Parse query parameters.
341342
viewParam := req.QueryParameter("view")
342343

344+
// Get nodes from the cluster session.
343345
clusterName := req.Attribute(COOKIE_CLUSTER_NAME_KEY).(string)
344346
clusterNamespace := req.Attribute(COOKIE_CLUSTER_NAMESPACE_KEY).(string)
345-
clusterNameID := clusterName + "_" + clusterNamespace
346-
347-
// A cluster lifecycle is identified by a cluster session.
348-
clusterSessionID := clusterNameID + "_" + sessionName
349-
nodeMap := s.eventHandler.GetNodeMap(clusterSessionID)
347+
clusterSessionKey := utils.BuildClusterSessionKey(clusterName, clusterNamespace, sessionName)
348+
nodeMap := s.eventHandler.GetNodeMap(clusterSessionKey)
350349

351-
// Handle different view types
350+
// Handle different view types.
352351
switch viewParam {
353352
case "hostNameList":
354353
s.getNodesHostNameList(nodeMap, resp)

0 commit comments

Comments
 (0)