Skip to content

Commit 5318a73

Browse files
machichimamachichima
authored
[TEST] Unit tests for ray_job_submission_service_server.go (#3532)
1 parent 2d6cdb1 commit 5318a73

File tree

6 files changed

+342
-51
lines changed

6 files changed

+342
-51
lines changed

‎apiserver/pkg/client/cluster.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import (
99
rayv1 "github.com/ray-project/kuberay/ray-operator/pkg/client/clientset/versioned/typed/ray/v1"
1010
)
1111

12+
//go:generate mockgen -source=cluster.go -destination=cluster_mock.go -package=client
13+
1214
type ClusterClientInterface interface {
1315
RayClusterClient(namespace string) rayv1.RayClusterInterface
1416
}

‎apiserver/pkg/client/cluster_mock.go‎

Lines changed: 49 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎apiserver/pkg/client/kubernetes_mock.go‎

Lines changed: 35 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎apiserver/pkg/manager/client_manager_mock.go‎

Lines changed: 34 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎apiserver/pkg/server/ray_job_submission_service_server.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ func (s *RayJobSubmissionServiceServer) getRayClusterURL(ctx context.Context, re
220220
return &url, nil
221221
}
222222

223+
// Internal method to convert RayJobInfo to JobSubmissionInfo
223224
func convertNodeInfo(info *utils.RayJobInfo) *api.JobSubmissionInfo {
224225
jsi := api.JobSubmissionInfo{
225226
Entrypoint: info.Entrypoint,

0 commit comments

Comments
 (0)