Declare JSON response type at router level

AndySung320 · AndySung320 · commit 9f8d4a62b247 · 2026-02-04T21:24:59.000-08:00
Signed-off-by: AndySung320 &lt;andysung0320@gmail.com&gt;
diff --git a/historyserver/pkg/historyserver/router.go b/historyserver/pkg/historyserver/router.go
@@ -134,6 +134,8 @@ func routerAPI(s *ServerHandler) {
 	ws.Route(ws.GET("/v0/tasks/timeline").To(s.getTasksTimeline).Filter(s.CookieHandle).
 		Doc("get tasks timeline").
 		Param(ws.QueryParameter("job_id", "filter by job_id")).
+		Param(ws.QueryParameter("download", "set to 1 to return response as attachment (timeline JSON file)")).
+		Produces(restful.MIME_JSON).
 		Writes("")) // Placeholder for specific return type
 }
 
@@ -1001,7 +1003,6 @@ func (s *ServerHandler) getTasksTimeline(req *restful.Request, resp *restful.Res
 		return
 	}
 
-	resp.Header().Set("Content-Type", "application/json")
 	// Support download parameter
 	if download == "1" {
 		nowStr := time.Now().Format("2006-01-02_15-04-05")

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,8 @@ func routerAPI(s *ServerHandler) {`
`134`	`134`	`ws.Route(ws.GET("/v0/tasks/timeline").To(s.getTasksTimeline).Filter(s.CookieHandle).`
`135`	`135`	`Doc("get tasks timeline").`
`136`	`136`	`Param(ws.QueryParameter("job_id", "filter by job_id")).`
	`137`	`+ Param(ws.QueryParameter("download", "set to 1 to return response as attachment (timeline JSON file)")).`
	`138`	`+ Produces(restful.MIME_JSON).`
`137`	`139`	`Writes("")) // Placeholder for specific return type`
`138`	`140`	`}`
`139`	`141`
`@@ -1001,7 +1003,6 @@ func (s ServerHandler) getTasksTimeline(req restful.Request, resp *restful.Res`
`1001`	`1003`	`return`
`1002`	`1004`	`}`
`1003`	`1005`
`1004`		`- resp.Header().Set("Content-Type", "application/json")`
`1005`	`1006`	`// Support download parameter`
`1006`	`1007`	`if download == "1" {`
`1007`	`1008`	`nowStr := time.Now().Format("2006-01-02_15-04-05")`