Update ray-operator/controllers/ray/utils/util.go

ryanaoleary · JiangJiaWei1103 · web-flow · commit a6fafe9e3883 · 2026-04-15T01:55:17.000-07:00
Co-authored-by: Jia-Wei Jiang &lt;36886416+JiangJiaWei1103@users.noreply.github.com&gt;
Signed-off-by: Ryan O'Leary &lt;113500783+ryanaoleary@users.noreply.github.com&gt;
diff --git a/ray-operator/controllers/ray/utils/util.go b/ray-operator/controllers/ray/utils/util.go
@@ -1059,8 +1059,12 @@ func IsHTTPRouteEqual(existing, desired *gwv1.HTTPRoute) bool {
 		return existing == desired
 	}
 
-	// Compare Hostnames
-	if !reflect.DeepEqual(existing.Spec.Hostnames, desired.Spec.Hostnames) {
+	// Compare Hostnames. Treat nil and empty slice as equivalent to avoid false positives
+	// caused by renormalization from the API server or the Gateway implementation.
+	if len(existing.Spec.Hostnames) != len(desired.Spec.Hostnames) {
+		return false
+	}
+	if len(existing.Spec.Hostnames) > 0 && !reflect.DeepEqual(existing.Spec.Hostnames, desired.Spec.Hostnames) {
 		return false
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1059,8 +1059,12 @@ func IsHTTPRouteEqual(existing, desired *gwv1.HTTPRoute) bool {`
`1059`	`1059`	`return existing == desired`
`1060`	`1060`	`}`
`1061`	`1061`
`1062`		`- // Compare Hostnames`
`1063`		`- if !reflect.DeepEqual(existing.Spec.Hostnames, desired.Spec.Hostnames) {`
	`1062`	`+ // Compare Hostnames. Treat nil and empty slice as equivalent to avoid false positives`
	`1063`	`+ // caused by renormalization from the API server or the Gateway implementation.`
	`1064`	`+ if len(existing.Spec.Hostnames) != len(desired.Spec.Hostnames) {`
	`1065`	`+ return false`
	`1066`	`+ }`
	`1067`	`+ if len(existing.Spec.Hostnames) > 0 && !reflect.DeepEqual(existing.Spec.Hostnames, desired.Spec.Hostnames) {`
`1064`	`1068`	`return false`
`1065`	`1069`	`}`
`1066`	`1070`