Skip to content

Commit d05964c

Browse files
authored
[Bug] TestRayServiceInPlaceUpdate is flaky (#2620)
1 parent ece1d34 commit d05964c

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

.github/workflows/e2e-tests-reusable-workflow.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
7575
set -euo pipefail
7676
cd ${{ inputs.dir-to-test }}
77-
go test -timeout 30m -v ./test/e2e -json 2>&1 | tee ${KUBERAY_TEST_OUTPUT_DIR}/gotest.log | gotestfmt
77+
go test -timeout 60m -v ./test/e2e -json 2>&1 | tee ${KUBERAY_TEST_OUTPUT_DIR}/gotest.log | gotestfmt
7878
7979
- name: Print KubeRay operator logs
8080
if: (!inputs.plugin-test) && always() && steps.deploy.outcome == 'success'

ray-operator/test/e2e/rayservice_in_place_update_test.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,14 @@ func TestRayServiceInPlaceUpdate(t *testing.T) {
5252
}, TestTimeoutShort).Should(WithTransform(sampleyaml.IsPodRunningAndReady, BeTrue()))
5353

5454
// test the default curl result
55-
// curl /fruit
56-
stdout, _ := curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
57-
g.Expect(stdout.String()).To(Equal("6"))
58-
// curl /calc
59-
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/calc", `["MUL", 3]`)
60-
g.Expect(stdout.String()).To(Equal("15 pizzas please!"))
55+
g.Eventually(func(g Gomega) {
56+
// curl /fruit
57+
stdout, _ := curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
58+
g.Expect(stdout.String()).To(Equal("6"))
59+
// curl /calc
60+
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/calc", `["MUL", 3]`)
61+
g.Expect(stdout.String()).To(Equal("15 pizzas please!"))
62+
}, TestTimeoutShort).Should(Succeed())
6163

6264
// In-place update
6365
// Parse ServeConfigV2 and replace the string in the simplest way to update it.
@@ -79,7 +81,7 @@ func TestRayServiceInPlaceUpdate(t *testing.T) {
7981
// Test the new price and factor
8082
g.Eventually(func(g Gomega) {
8183
// curl /fruit
82-
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
84+
stdout, _ := curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
8385
g.Expect(stdout.String()).To(Equal("8"))
8486
// curl /calc
8587
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/calc", `["MUL", 3]`)

0 commit comments

Comments
 (0)