Skip to content

Commit dc3b44f

Browse files
committed
[history server][e2e] Fix Azure dead cluster tests by injecting ray-cluster-id
The Azure dead cluster tests were failing because the collector uploaded logs to a path based on the hardcoded 'default' namespace, but the history server searched for clusters in the test namespace. Add --ray-cluster-id injection to ApplyAzureRayClusterWithCollector, matching the behavior of the S3 test helper, so logs are uploaded to the correct namespace-prefixed path.
1 parent d336ac1 commit dc3b44f

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

historyserver/test/support/azureblob.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,14 @@ func ApplyAzureRayClusterWithCollector(test Test, g *WithT, namespace *corev1.Na
139139
rayClusterFromYaml := DeserializeRayClusterYAML(test, AzureRayClusterManifestPath)
140140
rayClusterFromYaml.Namespace = namespace.Name
141141

142+
// Inject namespace name as ray-cluster-id for head group collector
143+
injectCollectorRayClusterID(rayClusterFromYaml.Spec.HeadGroupSpec.Template.Spec.Containers, namespace.Name)
144+
145+
// Inject namespace name as ray-cluster-id for worker group collectors
146+
for wg := range rayClusterFromYaml.Spec.WorkerGroupSpecs {
147+
injectCollectorRayClusterID(rayClusterFromYaml.Spec.WorkerGroupSpecs[wg].Template.Spec.Containers, namespace.Name)
148+
}
149+
142150
rayCluster, err := test.Client().Ray().RayV1().
143151
RayClusters(namespace.Name).
144152
Create(test.Ctx(), rayClusterFromYaml, metav1.CreateOptions{})

0 commit comments

Comments
 (0)