Skip to content

Commit f739e5a

Browse files
committed
docs: todo comment for submission_id
Signed-off-by: machichima <nary12321@gmail.com>
1 parent d204ef1 commit f739e5a

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

historyserver/pkg/historyserver/router.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,16 @@ func routerAPI(s *ServerHandler) {
118118
Param(ws.QueryParameter("attempt_number", "attempt_number (task retry attempt number, default: 0)")).
119119
Param(ws.QueryParameter("download_file", "download_file (true/false)")).
120120
Param(ws.QueryParameter("filter_ansi_code", "filter_ansi_code (true/false)")).
121+
// TODO: submission_id parameter is not currently supported.
122+
// To support it, we need to:
123+
// 1. Implement DRIVER_JOB_DEFINITION_EVENT processing in eventserver to store driver job info
124+
// (including driver_node_id from the export event)
125+
// 2. Add submission_id field to DriverJobDefinitionEvent in Ray (currently missing, tracked in
126+
// https://github.com/ray-project/ray/issues/60129)
127+
// 3. Create resolveSubmissionLogFilename() method to:
128+
// - Look up driver job by submission_id
129+
// - Get driver_node_id from stored event
130+
// - Return filename as "job-driver-{submission_id}.log"
121131
Produces("text/plain").
122132
Writes("")) // Placeholder for specific return type
123133

0 commit comments

Comments
 (0)