Just use shortOffset

longOffset vs. shortOffset doesn't matter. It's just for UI
purposes, as formatUtils formatTimeZone takes the time
zone names to derive the display, not offset.

Also fixed match bug where for GMT+0, Intl.DateTimeFormat
only prints "GMT", not e.g. "GMT+0".

Signed-off-by: Brendan Miller <6900229+bhmiller@users.noreply.github.com>

Author: bhmiller

python/ray/dashboard/client/src/common/timezone.ts

@@ -1,29 +1,14 @@
 const getCurrentUTCOffset = (timeZone: string) => {
   try {
     const date = new Date();
-    // Ideally this would be longOffset, but it's not supported in used version of node
     const formatter = new Intl.DateTimeFormat("en-US", {
       timeZone,
       timeZoneName: "shortOffset",
     });
-    // Extract the GMT offset part from the formatted string and ensure it has minutes
+    // Extract the GMT offset part from the formatted string
     const formatted = formatter.format(date);
-    const match = formatted.match(/GMT[+-]\d{1,2}(?::\d{2})?/);
-    if (match) {
-      // Ensure the offset has minutes and hours are padded (e.g., convert GMT+5 to GMT+05:00)
-      const offset = match[0];
-      if (!offset.includes(":")) {
-        return offset.replace(
-          /([+-])(\d{1,2})$/,
-          (_, sign, hours) => `${sign}${hours.padStart(2, "0")}:00`,
-        );
-      }
-      return offset.replace(
-        /([+-])(\d{1,2}):/,
-        (_, sign, hours) => `${sign}${hours.padStart(2, "0")}:`,
-      );
-    }
-    return "";
+    const match = formatted.match(/GMT([+-]\d{1,2}(?::\d{2})?)?/);
+    return match ? match[0] : "";
   } catch (e) {
     console.warn(`Error getting UTC offset for ${timeZone}:`, e);
     return "";

python/ray/dashboard/client/src/components/SearchComponent.tsx

@@ -122,11 +122,11 @@ export const SearchTimezone = ({
   });
 
   const browserTimezone = Intl.DateTimeFormat().resolvedOptions().timeZone;
-  const browserTz = timezones.find((t) => t.value === browserTimezone);
-  if (browserTz) {
+  const browserUtc = timezones.find((t) => t.value === browserTimezone)?.utc;
+  if (browserUtc) {
     options.unshift({
       value: browserTimezone,
-      utc: browserTz.utc,
+      utc: browserUtc,
       group: "System",
       country: "Browser Time",
     });