Skip to content

BUILD: patch zlib for macos and protobuf for windows #48794

@mattip

Description

@mattip

What happened + What you expected to happen

Over at conda-forge I needed to patch the grpc, boost, and prometheus-cpp build recipes to remove fdopen from zlib, which fails to compile when conda-forge updated to the azure macOS-13 image. The change is part of zlib-1.3.1.

I also needed to patch protobuf for newer windows SDK which no longer has a constant NAN, here is the upstream fix.

I think the best way forward would be to update the dependencies, but that might have unintended consequences. I could submit the patches I developed for the conda-forge build here, would that be welcome?

Versions / Dependencies

ray-2.39.0 built on Azure CI via conda-forge

Reproduction script

bazel --verbose_failures --local_cpu_resources=4 -- //:ray_pkg

Issue Severity

Medium: It is a significant difficulty but I can work around it.

Metadata

Metadata

Assignees

Labels

P1Issue that should be fixed within a few weeksbugSomething that is supposed to be working; but isn'tci-testcommunity-backlogcoreIssues that should be addressed in Ray Corestabilitytech-debtThe issue that's due to tech debtwindows

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions