refactor(wanda): test cases and Dockerfiles for 'hello' variants (#369)

Needed for subsequent work that will assume global uniqueness
between names

Topic: wanda-refactor-hello

Signed-off-by: andrew <andrew@anyscale.com>

Signed-off-by: andrew <andrew@anyscale.com>

Author: andrew-anyscale

wanda/forge_test.go

@@ -172,7 +172,7 @@ func TestForge_withHints(t *testing.T) {
 		t.Fatalf("build: %v", err)
 	}
 
-	const tag = "cr.ray.io/rayproject/hello"
+	const tag = "cr.ray.io/rayproject/hello-hint"
 
 	ref, err := name.ParseReference(tag)
 	if err != nil {
@@ -214,11 +214,11 @@ func TestForge(t *testing.T) {
 		NamePrefix: "cr.ray.io/rayproject/",
 	}
 
-	if err := Build("testdata/hello.wanda.yaml", config); err != nil {
+	if err := Build("testdata/hello-test.wanda.yaml", config); err != nil {
 		t.Fatalf("build: %v", err)
 	}
 
-	const tag = "cr.ray.io/rayproject/hello"
+	const tag = "cr.ray.io/rayproject/hello-test"
 
 	ref, err := name.ParseReference(tag)
 	if err != nil {
@@ -283,7 +283,7 @@ func TestForge_noCache(t *testing.T) {
 		t.Fatalf("build: %v", err)
 	}
 
-	const tag = "cr.ray.io/rayproject/hello"
+	const tag = "cr.ray.io/rayproject/hello-nocache"
 
 	ref, err := name.ParseReference(tag)
 	if err != nil {
@@ -362,7 +362,7 @@ func TestForgeWithRemoteWorkRepo(t *testing.T) {
 		Epoch:      "1",
 	}
 
-	if err := Build("testdata/hello.wanda.yaml", config); err != nil {
+	if err := Build("testdata/hello-test.wanda.yaml", config); err != nil {
 		t.Fatalf("build hello: %v", err)
 	}
 
@@ -405,7 +405,7 @@ func TestForgeWithRemoteWorkRepo(t *testing.T) {
 		t.Fatalf("make new forge: %v", err)
 	}
 
-	helloSpec, err := parseSpecFile("testdata/hello.wanda.yaml")
+	helloSpec, err := parseSpecFile("testdata/hello-test.wanda.yaml")
 	if err != nil {
 		t.Fatalf("parse hello spec: %v", err)
 	}
@@ -420,7 +420,7 @@ func TestForgeWithRemoteWorkRepo(t *testing.T) {
 		t.Errorf("got %d cache hits, want 1", hit)
 	}
 
-	hello := fmt.Sprintf("%s/work:def456-hello", crAddr)
+	hello := fmt.Sprintf("%s/work:def456-hello-test", crAddr)
 	helloRef, err := name.ParseReference(hello)
 	if err != nil {
 		t.Fatalf("parse hello reference: %v", err)
@@ -475,7 +475,7 @@ func TestForgeLocal_withNamePrefix(t *testing.T) {
 		Epoch:      randomEpoch(),
 	}
 
-	if err := Build("testdata/hello.wanda.yaml", config); err != nil {
+	if err := Build("testdata/hello-test.wanda.yaml", config); err != nil {
 		t.Fatalf("build hello: %v", err)
 	}
 
@@ -518,7 +518,7 @@ func TestForgeLocal_withNamePrefix(t *testing.T) {
 		t.Fatalf("make new forge: %v", err)
 	}
 
-	helloSpec, err := parseSpecFile("testdata/hello.wanda.yaml")
+	helloSpec, err := parseSpecFile("testdata/hello-test.wanda.yaml")
 	if err != nil {
 		t.Fatalf("parse hello spec: %v", err)
 	}
@@ -531,7 +531,7 @@ func TestForgeLocal_withNamePrefix(t *testing.T) {
 		t.Errorf("got %d cache hits, want 1", hit)
 	}
 
-	hello := "localhost:5000/rayci-work:abc123-hello"
+	hello := "localhost:5000/rayci-work:abc123-hello-test"
 	helloRef, err := name.ParseReference(hello)
 	if err != nil {
 		t.Fatalf("parse hello reference: %v", err)

wanda/testdata/Dockerfile.world

@@ -1,3 +1,3 @@
-FROM cr.ray.io/rayproject/hello
+FROM cr.ray.io/rayproject/hello-test
 
 COPY world.txt /opt/app/world.txt

wanda/testdata/hello-hint.wanda.yaml

@@ -1,4 +1,4 @@
-name: hello
+name: hello-hint
 dockerfile: Dockerfile.hello
 build_hint_args:
   - MESSAGE=hint message

wanda/testdata/hello-nocache.wanda.yaml

@@ -1,3 +1,3 @@
-name: hello
+name: hello-nocache
 dockerfile: Dockerfile.hello
 disable_caching: true

wanda/testdata/hello.wanda.yaml wanda/testdata/hello-test.wanda.yamlwanda/testdata/hello.wanda.yaml renamed to wanda/testdata/hello-test.wanda.yaml

@@ -1,2 +1,2 @@
-name: hello
+name: hello-test
 dockerfile: Dockerfile.hello

wanda/testdata/world.wanda.yaml

@@ -1,5 +1,5 @@
 name: world
 dockerfile: Dockerfile.world
-froms: [ "cr.ray.io/rayproject/hello" ]
+froms: [ "cr.ray.io/rayproject/hello-test" ]
 srcs:
   - world.txt