Skip to content

Commit 7a23151

Browse files
committed
Updated keywords to use new preference awareness and ensured favorites have keyword parity with timesheet view.
1 parent 4ee8ec2 commit 7a23151

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

extensions/harvest/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
- Fix: Time entry caching now only persists today's entries to prevent unlimited cache growth; utilizing cached promise data for other dates should work fine for most
88
- Fix: Favorites now store hours in decimal format internally to prevent display inconsistencies
99
- Fix: Improved precision when converting H:mm time format to decimal to prevent rounding errors
10+
- Fix: Added keywords to favorites to match filtering options used in Today's Timesheet
1011
- Changed: UI updates across list views
1112
- Added preference to select which field to use as primary title; other field becomes accessory
1213
- Converted project and client to accessories with icons

extensions/harvest/src/listFavorites.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,11 @@ export default function Command() {
195195
<List.Item
196196
key={favorite.id}
197197
title={titleDisplay === "task" ? favorite.taskName : favorite.projectName}
198-
keywords={favorite.notes?.split(" ")}
198+
keywords={[
199+
...(favorite.notes?.split(" ") ?? []),
200+
...(favorite.clientName?.split(" ") ?? []),
201+
...((titleDisplay === "task" ? favorite.projectName : favorite.taskName)?.split(" ") ?? []),
202+
]}
199203
accessories={[
200204
{
201205
text: titleDisplay === "task" ? favorite.projectName : favorite.taskName,

extensions/harvest/src/listTimeEntries.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export default function Command() {
247247
keywords={[
248248
...(entry.notes?.split(" ") ?? []),
249249
...(entry.client?.name?.split(" ") ?? []),
250-
...(entry.project?.name?.split(" ") ?? []),
250+
...((titleDisplay === "task" ? entry.project?.name : entry.task?.name)?.split(" ") ?? []),
251251
]}
252252
accessories={[
253253
{

0 commit comments

Comments
 (0)