Merge pull request #16 from raymondge/A-release

fix bugs

Author: raymondge

build.gradle

@@ -12,6 +12,8 @@ repositories {
 
 dependencies {
     implementation 'junit:junit:4.12'
+    implementation 'org.junit.jupiter:junit-jupiter:5.4.2'
+    implementation 'org.junit.jupiter:junit-jupiter:5.4.2'
     String javaFxVersion = '11'
 
     implementation group: 'org.openjfx', name: 'javafx-base', version: javaFxVersion, classifier: 'win'

docs/README.md

@@ -1,26 +1,37 @@
 # User Guide for duke bot
-
-## Features 
-
-### Say bye to duke `bye` 
+1. [Features](#1-features)<br>
+    1.1 [Say bye to duke: `bye`](#11-say-bye-to-duke-bye)<br>
+    1.2 [Find a task: `find`](#12-find-a-task-find)<br>
+    1.3 [Delete a task: `delete` ](#13-delete-a-task-delete)<br>
+    1.4 [Create a todo task: `todo`](#14-create-a-todo-task-todo)<br>
+    1.5 [Create a deadline task: `deadline`](#15-create-a-deadline-task-deadline)<br>
+    1.6 [Create a event task: `event`](#16-create-a-event-task-event)<br>
+    1.7 [List your tasks: `list`](#17-list-your-tasks-list)<br>
+    1.8 [Find out statistics: `stats`](#18-find-out-statistics-stats)<br>
+    1.9 [Says hi to duke: `hi`](#19-says-hi-to-duke-hi)<br>
+    2.0 [Mark your task done: `done`](#20-mark-your-task-done-done)<br>
+2. [Command Summary](#2-command-summary)
+## 1. Features 
+
+### 1.1 Say bye to duke `bye` 
 
 Exit the program.
 
 Input instruction: 
 
 `bye`
 
-### Find a task `find` 
+### 1.2 Find a task `find` 
 
-Find the expected task with given index in the task list.
+Find the expected task with given keyword.
 
 Input instruction: 
 
-`find` + `index`
+`find` + `keyword`
 
 Example of usage: find 1 
 
-### Delete a task `delete` 
+### 1.3 Delete a task `delete` 
 
 Delete the expected task with given index in the task list.
 
@@ -30,7 +41,7 @@ Input instruction:
 
 Example of usage: delete 1 
 
-### Create a todo task `todo` 
+### 1.4 Create a todo task `todo` 
 
 Create a task that you are going to do and store in the tasklist.
 
@@ -40,7 +51,7 @@ Input instruction:
 
 Example of usage: todo play games
 
-### Create a deadline task `deadline` 
+### 1.5 Create a deadline task `deadline` 
 
 Create a task with a deadline
 
@@ -50,7 +61,7 @@ Input instruction:
 
 Example of usage: deadline finish homework /by 2020-05-12
 
-### Create a event task `event` 
+### 1.6 Create a event task `event` 
 
 Create an event
 
@@ -60,7 +71,7 @@ Input instruction:
 
 Example of usage: event celebrate holiday /at 2020-05-12
 
-### List your tasks `list` 
+### 1.7 List your tasks `list` 
 
 Show the list of tasks
 
@@ -70,7 +81,7 @@ Input instruction:
 
 Example of usage: list
 
-### Find out statistics `stats` 
+### 1.8 Find out statistics `stats` 
 
 Show the number of task completed
 
@@ -80,7 +91,7 @@ Input instruction:
 
 Example of usage: stats
 
-### Says hi to duke `hi` 
+### 1.9 Says hi to duke `hi` 
 
 Greet the bot and it will greet you back
 
@@ -90,7 +101,7 @@ Input instruction:
 
 Example of usage: hi
 
-### Mark your task done `done` 
+### 2.0 Mark your task done `done` 
 
 Mark your task done 
 
@@ -100,6 +111,20 @@ Input instruction:
 
 Example of usage: done 1
 
+## 2. Command summary
+
+Action | Format, Examples
+--------|------------------
+**Find Task** | `find keyword` <br> e.g.,`find homework`
+**Delete Task** | `delete index`<br> e.g.,`delete 1`
+**Todo Task** | `todo description` <br> e.g., `doto play games`
+**Deadline Task** | `deadline description /by YYYY-MM-DD` <br> e.g., `deadline finish homework /by 2020-05-12`
+**Event Task** | `event description /at YYYY-MM-DD` <br> e.g., `event celebrate holiday /at 2020-05-12`
+**List Task** | `list` <br>
+**Stats** | `stats` <br>
+**Done** | `done index ` <br> e.g., `done 1`
+**Bye** | `bye`<br>
+
 //@@author dcchan98-reused
 //Reused from https://github.com/dcchan98/ip/blob/master/src/main/java/Storage.java with minor modification
 

src/main/java/Parser.java

@@ -71,7 +71,7 @@ public String uiResponse(TaskList tasks, UI ui,String uiInput) {
                         throw new InvalidEventException();
                     }
                     try {
-                        String[] tempString = textMessage.substring(7).split(" /at ");
+                        String[] tempString = textMessage.substring(6).split(" /at ");
                         Event newEvent = new Event(tempString[0], false, LocalDate.parse(tempString[1]));
                         response += tasks.addTask(newEvent);
                     } catch (Exception e) {

src/main/java/TaskList.java

@@ -25,6 +25,10 @@ public String findTask(String keyword) {
 
         }
 
+        if (listOfFoundItems.size() == 0) {
+            return "No matching task is found!";
+        }
+
         int iterator = 1;
         output += "Here are the matching tasks in your list:\n";
 
@@ -53,6 +57,9 @@ public String addTask(Task myTask) {
      * @return the String for task deleted.
      */
     public String deleteTask(int index) {
+        if (this.tasks.size() <= index) {
+            return "The index you entered is too large!";
+        }
         assert this.tasks.size() > index;
         Task myTask = this.tasks.get(index);
         this.tasks.remove(index);

src/test/java/DukeTest.java

@@ -0,0 +1,30 @@
+import org.junit.jupiter.api.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class ParserTest {
+
+    @Test
+    public void testParseDeadLine() {
+        UI ui = new UI();
+        TaskList tasks = new TaskList();
+        String respond = "added: [D][" + "\u2718" + "] finish homework (by: May 12 2020)";
+        try {
+            assertEquals(respond, new Parser().uiResponse(tasks,ui,"deadline finish homework /by 2020-05-12"));
+        } catch (Exception e) {
+            System.out.println(e);
+        }
+    }
+
+    @Test
+    public void testParseEvent() {
+        UI ui = new UI();
+        TaskList tasks = new TaskList();
+        String respond = "added: [E][" + "\u2718" + "] finish homework (at: 12 May 2020)";
+        try {
+            assertEquals(respond, new Parser().uiResponse(tasks,ui,"event finish homework /at 2020-05-12"));
+        } catch (Exception e) {
+            System.out.println(e);
+        }
+    }
+}