Fixed pom.xml and JavaDocs

Author: foxfirecodes

Diff for: pom.xml

@@ -14,6 +14,7 @@
     <properties>
         <java.version>1.8</java.version>
         <bukkit.version>1.12.2-R0.1-SNAPSHOT</bukkit.version>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     </properties>
 
     <repositories>
@@ -46,6 +47,15 @@
         </dependency>
     </dependencies>
 
+
+    <distributionManagement>
+        <repository>
+            <id>internal.repo</id>
+            <name>Build repo</name>
+            <url>file://${basedir}/../maven-repo</url>
+        </repository>
+    </distributionManagement>
+
     <build>
         <defaultGoal>clean test package</defaultGoal>
         <finalName>${project.name}-${project.version}</finalName>
@@ -63,7 +73,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.7.0</version>
+                <version>3.8.1</version>
                 <configuration>
                     <source>${java.version}</source>
                     <target>${java.version}</target>
@@ -90,7 +100,46 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <artifactId>maven-source-plugin</artifactId>
+                <version>3.1.0</version>
+                <executions>
+                    <execution>
+                        <id>attach-sources</id>
+                        <phase>deploy</phase>
+                        <goals>
+                            <goal>jar-no-fork</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <version>3.1.1</version>
+                <executions>
+                    <execution>
+                        <id>attach-javadocs</id>
+                        <phase>deploy</phase>
+                        <goals>
+                            <goal>jar</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <!-- explicitly define maven-deploy-plugin after other to force exec order -->
+                <artifactId>maven-deploy-plugin</artifactId>
+                <version>3.0.0-M1</version>
+                <executions>
+                    <execution>
+                        <id>deploy</id>
+                        <phase>deploy</phase>
+                        <goals>
+                            <goal>deploy</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
-
-</project>
+</project>

Diff for: src/main/java/me/rayzr522/flash/FlashPlugin.java

@@ -99,8 +99,8 @@ public CommandRegister getCommandRegister() {
      *
      * @param sender      The {@link CommandSender} to check.
      * @param permission  The permission to check.
-     * @param sendMessage
-     * @return
+     * @param sendMessage Whether or not to send a message saying they are missing permissions.
+     * @return Whether or not the user has the given permission.
      */
     public boolean checkPermission(CommandSender sender, String permission, boolean sendMessage) {
         Objects.requireNonNull(sender, "sender cannot be null!");

Diff for: src/main/java/me/rayzr522/flash/gui/RenderTarget.java

@@ -45,8 +45,9 @@ public interface RenderTarget {
 
     /**
      * Returns a sub-render target that can only modify things in the given range.
-     * <p>
-     * <p>All subsequent render calls to this target will be <em>relative to its [minX,minY]
+     * <br>
+     * <br>
+     * All subsequent render calls to this target will be <em>relative to its [minX,minY]
      * point!</em>
      *
      * @param minX the minimum x this target can draw (inclusive)
@@ -75,8 +76,8 @@ public interface RenderTarget {
 
     /**
      * Sets the {@link Gui} this target belongs to.
-     * <p>
-     * <p><br>You should likely <em>not</em> call this.
+     * <br>
+     * <br>You should likely <em>not</em> call this.
      *
      * @param gui the gui this target belongs to
      */

Diff for: src/main/java/me/rayzr522/flash/gui/display/Node.java

@@ -58,8 +58,8 @@ protected Optional<RenderTarget> getRenderTarget() {
 
     /**
      * The internal method used for rendering this component.
-     * <p>
-     * <p><em>Do <strong>not</strong> call this yourself. In fact, you shouldn't call {@link #render(RenderTarget)}
+     * <br>
+     * <br><em>Do <strong>not</strong> call this yourself. In fact, you shouldn't call {@link #render(RenderTarget)}
      * either...</em>
      *
      * @param target the target to render with

Diff for: src/main/java/me/rayzr522/flash/gui/display/Pane.java

@@ -101,8 +101,8 @@ public Optional<Node> getNodeAt(int x, int y) {
 
     /**
      * Registers a node as a child of this. Needed to correctly watch for changes.
-     * <p>
-     * After calling this method, {@link #getChildren()} will contain the passed node
+     * <br>
+     * <br>After calling this method, {@link #getChildren()} will contain the passed node
      *
      * @param child the child to add
      */
@@ -114,8 +114,8 @@ protected void registerChild(Node child) {
 
     /**
      * Removes a child from this pane.
-     * <p>
-     * After calling this method, {@link #getChildren()} will no longer contain the passed node and the area it made up
+     * <br>
+     * <br>After calling this method, {@link #getChildren()} will no longer contain the passed node and the area it made up
      * will be cleared.
      *
      * @param node the node to remove
@@ -183,8 +183,8 @@ protected void updateChildBounds(Node child) {
 
     /**
      * Computes the bounds of the child. First value is the xRange, second the yRange.
-     * <p>
-     * <p><br>Both are zero based and inclusive
+     * <br>
+     * <br>Both are zero based and inclusive
      *
      * @param child the child to compute the bounds for
      * @return the computed bounds

Diff for: src/main/java/me/rayzr522/flash/gui/display/component/Button.java

@@ -64,8 +64,8 @@ public Button(Material material, String label) {
 
     /**
      * Sets the action to run when the button is clicked.
-     * <p>
-     * <p><br>The event is always cancelled before this handler is called.
+     * <br>
+     * <br>The event is always cancelled before this handler is called.
      *
      * @param onClick the click handler
      * @return this button

Diff for: src/main/java/me/rayzr522/flash/gui/display/panes/FlowPane.java

@@ -115,8 +115,8 @@ private boolean placeChild(Node node) {
 
     /**
      * Tries to find a free position where a rectangle with the given size can fit.
-     * <p>
-     * This is a variant of the bin packing problem, and my algorithm is awesome for it: Slow and finds not even a
+     * <br>
+     * <br>This is a variant of the bin packing problem, and my algorithm is awesome for it: Slow and finds not even a
      * local maximum.
      *
      * @param width  the width of the space to find
@@ -190,9 +190,9 @@ public enum Alignment {
         /**
          * Aligns children in a center-first fashion. It will check the middle of the row and then expand to the two
          * sides, going left first.
-         * <p>
+         * <br>
          * Example (Inserting A, B, C):
-         * <p>
+         * <br>
          * <pre>
          *     ___
          *
@@ -223,9 +223,9 @@ Pair<Integer, Integer> findFreeSpace(FlowPane pane, int width, int height) {
         },
         /**
          * Aligns children from left to right, top to bottom
-         * <p>
+         * <br>
          * Example (Inserting A, B, C):
-         * <p>
+         * <br>
          * <pre>
          *     ___
          *
@@ -253,12 +253,12 @@ Pair<Integer, Integer> findFreeSpace(FlowPane pane, int width, int height) {
         },
         /**
          * Aligns children from top to bottom, left to right
-         * <p>
+         * <br>
          * Example (Inserting A, B, C):
-         * <p>
+         * <br>
          * <pre>
          *     _       A       A       A
-         *     _  ==>  _  ==>  B  ==>  B
+         *     _  ==&gt;  _  ==&gt;  B  ==&gt;  B
          *     _       _       _       C
          * </pre>
          */

Diff for: src/main/java/me/rayzr522/flash/gui/display/panes/GridPane.java

@@ -16,8 +16,8 @@ public class GridPane extends Pane {
 
     /**
      * Creates a new {@link GridPane} with the given settings.
-     * <p>
-     * <p><br>The {@link #getGridWidth()} and {@link #getGridHeight()} are computed by diving the width/height with
+     * <br>
+     * <br>The {@link #getGridWidth()} and {@link #getGridHeight()} are computed by diving the width/height with
      * the rows/columns. This automatically floors the value.
      *
      * @param width   the width of this pane

Diff for: src/main/java/me/rayzr522/flash/gui/flow/FlowInventoryGui.java

@@ -46,6 +46,7 @@ public FlowInventoryGui<T> rows(int rows) {
      * Sets the root pane for the {@link Gui}. The default is a {@link FlowPane} spanning the whole area.
      *
      * @param pane the root pane
+     * @param <Z>  the type of pane that is being set as the root
      * @return this object
      */
     @SuppressWarnings("unchecked")

Diff for: src/main/java/me/rayzr522/flash/gui/render/InventoryRenderTarget.java

@@ -44,8 +44,8 @@ public InventoryRenderTarget(int width, int height, @Nullable String title) {
 
     /**
      * Creates a new {@link InventoryRenderTarget} that can draw inside the given bounds, starting at the origin.
-     * <p>
-     * <p><br>The title will be null, so display the default.
+     * <br>
+     * <br>The title will be null, so display the default.
      *
      * @param width  the width it can draw inside
      * @param height the height it can draw inside.