Skip to content

Commit 174a199

Browse files
saurav12claude
andauthored
fix(tokens): drop the needs-attention suffix from the token push PR title (#3929)
A token push that could not verify itself titled its PR 'feat(tokens): update tokens from figma (needs attention)'. The suffix outlives the problem: draft state and the blocking section in the body both clear themselves as the PR is fixed and marked ready, but the title has to be edited by hand, and this repo squash-merges with the PR title as the commit message. Miss the cleanup and '(needs attention)' lands on master permanently, as very nearly happened on #3925. Draft state already carries the signal, and the reasons stay in the body. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent a61f11e commit 174a199

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

packages/blade/scripts/uploadTokens.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -500,17 +500,17 @@ const uploadColorTokens = async () => {
500500
});
501501
execa.commandSync(`git push origin ${branchName}`, { cwd: REPO_ROOT });
502502

503-
const title = blockers.length
504-
? 'feat(tokens): update tokens from figma (needs attention)'
505-
: 'feat(tokens): update tokens from figma';
506-
503+
// The title is constant. Draft state carries "this could not verify itself", and the reasons are
504+
// written into the body — both of which clear themselves as the PR is fixed and marked ready. A
505+
// marker in the title does not: it survives into the squashed commit on master unless somebody
506+
// remembers to strip it, which is exactly the kind of cleanup that gets missed.
507507
execa.sync(
508508
'gh',
509509
[
510510
'pr',
511511
'create',
512512
'--title',
513-
title,
513+
'feat(tokens): update tokens from figma',
514514
'--head',
515515
branchName,
516516
'--repo',

0 commit comments

Comments
 (0)