Showing proper player server ID and names in debug menus

Author: razzie

Client/Common.cs

@@ -8,6 +8,11 @@ namespace PocceMod.Client
 {
     public static class Common
     {
+        public static int PlayerID
+        {
+            get { return API.GetPlayerServerId(API.PlayerId()); }
+        }
+
         public static void Notification(string message, bool blink = false, bool saveToBrief = false)
         {
             API.SetNotificationTextEntry("CELL_EMAIL_BCON");

Client/Menus/Dev/DebugMenu.cs

@@ -1,5 +1,4 @@
-using CitizenFX.Core.Native;
-using MenuAPI;
+using MenuAPI;
 using PocceMod.Shared;
 
 namespace PocceMod.Client.Menus.Dev
@@ -18,7 +17,8 @@ private enum ConfigKind
 
         public DebugMenu() : base("PocceMod", "debug menu")
         {
-            AddMenuItem(new MenuItem("PlayerID") { Label = API.PlayerId().ToString() });
+            var serverIDItem = new MenuItem("Player server ID");
+            AddMenuItem(serverIDItem);
 
             var permissionGroupItem = new MenuItem("Permission group") { Enabled = false };
             AddMenuItem(permissionGroupItem);
@@ -55,6 +55,8 @@ public DebugMenu() : base("PocceMod", "debug menu")
 
             OnMenuOpen += (_menu) =>
             {
+                serverIDItem.Label = Common.PlayerID.ToString();
+
                 if (!permissionGroupItem.Enabled && Permission.GetPlayerGroup(out Permission.Group permissionGroup))
                 {
                     permissionGroupItem.Label = permissionGroup.ToString();

Client/Menus/Dev/TelemetryMenu.cs

@@ -1,4 +1,5 @@
-using MenuAPI;
+using CitizenFX.Core.Native;
+using MenuAPI;
 
 namespace PocceMod.Client.Menus.Dev
 {
@@ -19,7 +20,9 @@ public TelemetryMenu() : base("PocceMod", "telemetry menu")
             {
                 foreach (var playerTelemetry in Telemetry.Entries)
                 {
-                    var menuItem = new MenuItem("player#" + playerTelemetry.Key) { ItemData = playerTelemetry.Value };
+                    var player = playerTelemetry.Key;
+                    var playerName = API.GetPlayerName(API.GetPlayerFromServerId(player));
+                    var menuItem = new MenuItem(string.Format("{0} (#{1})", playerName, player)) { ItemData = playerTelemetry.Value };
                     AddMenuItem(menuItem);
                 }
             };