Skip to content

Commit a5064b7

Browse files
committed
Hide server signature algorithms by default. Fixes #236
1 parent 1530435 commit a5064b7

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

Changelog

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
Changelog
22
=========
3+
Version: 2.0.7
4+
Date : 10/02/2021
5+
Author : rbsec <robin@rbsec.net>
6+
Changes: The following are a list of changes
7+
> Don't show server signature algorithms by default
8+
> Use --show-sigs to display them
9+
310
Version: 2.0.6
411
Date : 31/10/2020
512
Author : rbsec <robin@rbsec.net>
613
Changes: The following are a list of changes
714
> Flag certificates in red if CN is the same as issuer
815

9-
Version: 2.0.4
1016
Version: 2.0.5
1117
Date : 24/10/2020
1218
Author : rbsec <robin@rbsec.net>

sslscan.1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ Do not check for OpenSSL Heartbleed (CVE-2014-0160)
127127
.B \-\-no\-groups
128128
Do not enumerate key exchange groups
129129
.TP
130-
.B \-\-no\-sigs
131-
Do not enumerate signature algorithms
130+
.B \-\-show\-sigs
131+
Enumerate signature algorithms
132132
.TP
133133
.B \-\-starttls\-ftp
134134
STARTTLS setup for FTP

sslscan.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3605,7 +3605,7 @@ int main(int argc, char *argv[])
36053605
sslOptions.compression = true;
36063606
sslOptions.heartbleed = true;
36073607
sslOptions.groups = true;
3608-
sslOptions.signature_algorithms = true;
3608+
sslOptions.signature_algorithms = false;
36093609
sslOptions.starttls_ftp = false;
36103610
sslOptions.starttls_imap = false;
36113611
sslOptions.starttls_irc = false;
@@ -3782,13 +3782,13 @@ int main(int argc, char *argv[])
37823782
else if (strcmp("--no-heartbleed", argv[argLoop]) == 0)
37833783
options->heartbleed = false;
37843784

3785-
// Should we check for key exchange groups?
3786-
else if (strcmp("--no-groups", argv[argLoop]) == 0)
3785+
// Should we check for key exchange groups?
3786+
else if (strcmp("--no-groups", argv[argLoop]) == 0)
37873787
options->groups = false;
37883788

3789-
// Should we check for signature algorithms?
3790-
else if (strcmp("--no-sigs", argv[argLoop]) == 0)
3791-
options->signature_algorithms = false;
3789+
// Should we check for signature algorithms?
3790+
else if (strcmp("--show-sigs", argv[argLoop]) == 0)
3791+
options->signature_algorithms = true;
37923792

37933793
// StartTLS... FTP
37943794
else if (strcmp("--starttls-ftp", argv[argLoop]) == 0)
@@ -4080,7 +4080,7 @@ int main(int argc, char *argv[])
40804080
printf(" %s--no-groups%s Do not enumerate key exchange groups\n", COL_GREEN, RESET);
40814081
printf(" %s--no-heartbleed%s Do not check for OpenSSL Heartbleed (CVE-2014-0160)\n", COL_GREEN, RESET);
40824082
printf(" %s--no-renegotiation%s Do not check for TLS renegotiation\n", COL_GREEN, RESET);
4083-
printf(" %s--no-sigs%s Do not enumerate signature algorithms\n", COL_GREEN, RESET);
4083+
printf(" %s--show-sigs%s Enumerate signature algorithms\n", COL_GREEN, RESET);
40844084
printf("\n");
40854085
printf(" %s--starttls-ftp%s STARTTLS setup for FTP\n", COL_GREEN, RESET);
40864086
printf(" %s--starttls-imap%s STARTTLS setup for IMAP\n", COL_GREEN, RESET);

0 commit comments

Comments
 (0)