import signature (in practice) incompatible with Sink #67

Activity

1. RubenVerborgh

   added

   bugSomething isn't workingSomething isn't working

   on Mar 28, 2022
2. bergos commented on Mar 29, 2022

   

   bergos

   on Mar 29, 2022

   Member

   More actions

   It would be the same for the match method. I don't think it makes sense to prefix or postfix the methods to distinguish them. The stream and dataset interfaces are for different use cases. The import method of the Dataset is the only method that consumes a Stream and creates a bridge between both worlds. As the Stream is just consumed, using the Dataset interface doesn't require deeper knowledge about the Stream interface. The name import is the best match for this use case. For the rare case where you want to have both interfaces, it's probably better to use different objects for each interface. Like this:

   const dataset = factory.dataset()
   const store = new DatasetStore(dataset) 
   
   // store.dataset implements the Dataset interface
   await store.dataset.import(quadStream)
   
   // store implements the Store interface
   store.match().on('data', quad => console.log(quad))