Skip to content

Assumes WebGLObjects are extensible and include an Object prototype #463

Open
@estobbart

Description

@estobbart

The spec doesn't seem to be very clear on WebGLObjects.
But w/ WebGLTexture objects, Lightning attempts to assign it's own properties..

https://github.com/rdkcentral/Lightning/blob/master/src/renderer/webgl/WebGLRenderer.mjs#L217-L218

Here it uses a WebGLTexture to call hasOwnProperty
https://github.com/rdkcentral/Lightning/blob/master/src/tree/TextureManager.mjs#L123

This seems to not be a problem with most browser implementations, but could be an issue with more esoteric platforms.

Wanted to get feedback on this prior to any contribution.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    On Hold

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions