[plugins] Remove ConnectionID from applicable SmartInterfaceTypes (#1895)

(breaking)

Co-authored-by: Pierre Wielders <[email protected]>

Author: MFransen69

Source/plugins/Types.h

@@ -287,7 +287,6 @@ namespace RPC {
             : _controller(nullptr)
             , _administrator(channelWaitTime)
             , _monitor(*this)
-            , _connectionId(~0)
         {
         }
 POP_WARNING()
@@ -297,10 +296,6 @@ POP_WARNING()
         }
 
     public:
-        DEPRECATED uint32_t ConnectionId() const
-        {
-            return (_connectionId);
-        }
         bool IsOperational() const
         {
             return (_monitor.IsOperational());
@@ -321,10 +316,6 @@ POP_WARNING()
             }
             if (_controller != nullptr) {
                 _monitor.Register(_controller, callsign);
-                Core::ProxyType<CommunicatorClient> channel(_administrator.Communicator(node));
-                if (channel.IsValid() == true) {
-                    _connectionId = channel->ConnectionId();
-                }
             }
 
             return (_controller != nullptr ? Core::ERROR_NONE : Core::ERROR_UNAVAILABLE);
@@ -400,7 +391,6 @@ POP_WARNING()
         PluginHost::IShell* _controller;
         ConnectorType<ENGINE> _administrator;
         Monitor _monitor;
-        uint32_t _connectionId;
     };
 
 /*
@@ -565,7 +555,6 @@ POP_WARNING()
         explicit SmartControllerInterfaceType(const uint32_t channelWaitTime = Core::infinite)
             : _controller(nullptr)
             , _administrator(channelWaitTime)
-            , _connectionId(~0)
         {
         }
 
@@ -575,10 +564,6 @@ POP_WARNING()
         }
 
     public:
-        DEPRECATED uint32_t ConnectionId() const
-        {
-            return (_connectionId);
-        }
         bool IsOperational() const
         {
             return (_controller != nullptr);
@@ -597,12 +582,6 @@ POP_WARNING()
             if (_controller == nullptr) {
                 _controller = _administrator.template Acquire<PluginHost::IShell>(waitTime, node, _T(""), ~0);
             }
-            if (_controller != nullptr) {
-                Core::ProxyType<CommunicatorClient> channel(_administrator.Communicator(node));
-                if (channel.IsValid() == true) {
-                    _connectionId = channel->ConnectionId();
-                }
-            }
 
             return (_controller != nullptr ? Core::ERROR_NONE : Core::ERROR_UNAVAILABLE);
         }
@@ -651,7 +630,6 @@ POP_WARNING()
     private:
         PluginHost::IShell* _controller;
         ConnectorType<ENGINE> _administrator;
-        uint32_t _connectionId;
     };
 
 }