Skip to content

Commit c9baec4

Browse files
committed
fix(log): remove duplicate qCritical logs
Remove redundant qCritical calls that duplicate DLOG error messages to avoid redundant error output in log files. 移除重复的qCritical调用,避免与DLOG重复输出错误日志。 Log: 移除重复的qCritical日志 PMS: BUG-349919 Influence: 移除重复的错误日志输出,统一使用DLOG记录错误,减少日志冗余。
1 parent 08959dd commit c9baec4

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

src/lib/cooperation/dfmplugin/reportlog/reportlogmanager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void ReportLogManager::init()
4242
qDebug() << "Created ReportLogWorker instance";
4343

4444
if (!reportWorker->init()) {
45-
qCritical() << "Failed to initialize ReportLogWorker";
45+
qWarning() << "Failed to initialize ReportLogWorker";
4646
reportWorker->deleteLater();
4747
return;
4848
}

src/lib/data-transfer/core/gui/getbackup/zipworker.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ bool ZipWork::addFileToZip(const QString &filePath, const QString &relativeTo, Q
109109

110110
QFile sourceFile(filePath);
111111
if (!sourceFile.open(QIODevice::ReadOnly)) {
112-
qCritical() << "Error reading source file:" << filePath;
113112
DLOG << "Failed to open source file for reading:" << filePath.toStdString();
114113
// backup file false
115114
sendBackupFileFailMessage(filePath);
@@ -120,7 +119,6 @@ bool ZipWork::addFileToZip(const QString &filePath, const QString &relativeTo, Q
120119
QString destinationFileName = QDir(relativeTo).relativeFilePath(filePath);
121120
QuaZipNewInfo newInfo(destinationFileName, sourceFile.fileName());
122121
if (!destinationFile.open(QIODevice::WriteOnly, newInfo)) {
123-
qCritical() << "Error writing to ZIP file for:" << filePath;
124122
DLOG << "Failed to open destination file in ZIP for writing:" << filePath.toStdString();
125123
// backup file false
126124

@@ -136,7 +134,6 @@ bool ZipWork::addFileToZip(const QString &filePath, const QString &relativeTo, Q
136134
if (bytesRead == -1) {
137135
DLOG << "Error reading from source file:" << filePath.toStdString();
138136
free(buffer);
139-
qCritical() << "Error reading from source file:" << filePath;
140137
destinationFile.close();
141138
sourceFile.close();
142139
sendBackupFileFailMessage(filePath);
@@ -147,7 +144,6 @@ bool ZipWork::addFileToZip(const QString &filePath, const QString &relativeTo, Q
147144
if (bytesWritten == -1) {
148145
DLOG << "Error writing to ZIP file for:" << filePath.toStdString();
149146
free(buffer);
150-
qCritical() << "Error writing to ZIP file for:" << filePath;
151147
destinationFile.close();
152148
sourceFile.close();
153149
sendBackupFileFailMessage(filePath);
@@ -207,7 +203,6 @@ bool ZipWork::backupFile(const QStringList &entries, const QString &destinationZ
207203
QElapsedTimer timer;
208204
zip.setFileNameCodec("UTF-8");
209205
if (!zip.open(QuaZip::mdCreate)) {
210-
qCritical("Error creating the ZIP file.");
211206
DLOG << "Failed to create ZIP file:" << destinationZipFile.toStdString();
212207
// backup file false
213208
sendBackupFileFailMessage(destinationZipFile);
@@ -241,7 +236,6 @@ bool ZipWork::backupFile(const QStringList &entries, const QString &destinationZ
241236
DLOG << "ZIP file closed, verifying integrity...";
242237

243238
if (zip.getZipError() != UNZ_OK) {
244-
qCritical() << "Error while compressing. Error code:" << zip.getZipError();
245239
DLOG << "Error during compression, ZIP error code:" << zip.getZipError();
246240
// backup file false
247241

0 commit comments

Comments
 (0)