Skip to content

Commit c3cf44e

Browse files
committed
fix: right click should not trigger drag
1 parent 5c90b97 commit c3cf44e

File tree

2 files changed

+25
-3
lines changed

2 files changed

+25
-3
lines changed

src/hooks/useScrollDrag.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default function useScrollDrag(
4040

4141
const onMouseDown = (e: MouseEvent) => {
4242
// Skip if element set draggable
43-
if ((e.target as HTMLElement).draggable) {
43+
if ((e.target as HTMLElement).draggable || e.button !== 0) {
4444
return;
4545
}
4646
// Skip if nest List has handled this event

tests/scroll.test.js

+24-2
Original file line numberDiff line numberDiff line change
@@ -577,8 +577,10 @@ describe('List.Scroll', () => {
577577
});
578578

579579
describe('mouse down drag', () => {
580-
function dragDown(container, mouseY) {
581-
fireEvent.mouseDown(container.querySelector('li'));
580+
function dragDown(container, mouseY, button = 0) {
581+
fireEvent.mouseDown(container.querySelector('li'), {
582+
button,
583+
});
582584

583585
let moveEvent = createEvent.mouseMove(container.querySelector('li'));
584586
moveEvent.pageY = mouseY;
@@ -621,6 +623,26 @@ describe('List.Scroll', () => {
621623
expect(getScrollTop(container)).toBe(0);
622624
});
623625

626+
it('right click should not move', () => {
627+
const onScroll = jest.fn();
628+
const { container } = render(
629+
<List
630+
component="ul"
631+
itemKey="id"
632+
itemHeight={20}
633+
height={100}
634+
data={genData(100)}
635+
onScroll={onScroll}
636+
>
637+
{({ id }) => <li>{id}</li>}
638+
</List>,
639+
);
640+
641+
// Drag down
642+
dragDown(container, 100, 2);
643+
expect(getScrollTop(container)).toBe(0);
644+
});
645+
624646
it('can not move when item add draggable', () => {
625647
const onScroll = jest.fn();
626648
const { container } = render(

0 commit comments

Comments
 (0)