Skip to content

Commit fd025df

Browse files
authored
fix: Add DLL file information resource file to ReactNativePicker windows (#444)
1 parent 539f018 commit fd025df

File tree

4 files changed

+128
-3
lines changed

4 files changed

+128
-3
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,100 @@
1+
// Microsoft Visual C++ generated resource script.
2+
//
3+
#include "resource.h"
4+
5+
#define APSTUDIO_READONLY_SYMBOLS
6+
/////////////////////////////////////////////////////////////////////////////
7+
//
8+
// Generated from the TEXTINCLUDE 2 resource.
9+
//
10+
#include "winres.h"
11+
12+
/////////////////////////////////////////////////////////////////////////////
13+
#undef APSTUDIO_READONLY_SYMBOLS
14+
15+
/////////////////////////////////////////////////////////////////////////////
16+
// English (United States) resources
17+
18+
#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_ENU)
19+
LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
20+
#pragma code_page(1252)
21+
22+
#ifdef APSTUDIO_INVOKED
23+
/////////////////////////////////////////////////////////////////////////////
24+
//
25+
// TEXTINCLUDE
26+
//
27+
28+
1 TEXTINCLUDE
29+
BEGIN
30+
"resource.h\0"
31+
END
32+
33+
2 TEXTINCLUDE
34+
BEGIN
35+
"#include ""winres.h""\r\n"
36+
"\0"
37+
END
38+
39+
3 TEXTINCLUDE
40+
BEGIN
41+
"\r\n"
42+
"\0"
43+
END
44+
45+
#endif // APSTUDIO_INVOKED
46+
47+
48+
/////////////////////////////////////////////////////////////////////////////
49+
//
50+
// Version
51+
//
52+
53+
VS_VERSION_INFO VERSIONINFO
54+
FILEVERSION 2,4,4,0
55+
PRODUCTVERSION 2,4,4,0
56+
FILEFLAGSMASK 0x3fL
57+
#ifdef _DEBUG
58+
FILEFLAGS 0x1L
59+
#else
60+
FILEFLAGS 0x0L
61+
#endif
62+
FILEOS 0x40004L
63+
FILETYPE 0x2L
64+
FILESUBTYPE 0x0L
65+
BEGIN
66+
BLOCK "StringFileInfo"
67+
BEGIN
68+
BLOCK "040904b0"
69+
BEGIN
70+
VALUE "CompanyName", "@react-native-picker"
71+
VALUE "FileDescription", "React Native Picker for Windows"
72+
VALUE "FileVersion", "2.4.4.0"
73+
VALUE "InternalName", "ReactNativePicker.dll"
74+
VALUE "LegalCopyright", "Copyright (C) 2022"
75+
VALUE "OriginalFilename", "ReactNativePicker.dll"
76+
VALUE "ProductName", "ReactNativePicker.dll"
77+
VALUE "ProductVersion", "2.4.4.0"
78+
END
79+
END
80+
BLOCK "VarFileInfo"
81+
BEGIN
82+
VALUE "Translation", 0x409, 1200
83+
END
84+
END
85+
86+
#endif // English (United States) resources
87+
/////////////////////////////////////////////////////////////////////////////
88+
89+
90+
91+
#ifndef APSTUDIO_INVOKED
92+
/////////////////////////////////////////////////////////////////////////////
93+
//
94+
// Generated from the TEXTINCLUDE 3 resource.
95+
//
96+
97+
98+
/////////////////////////////////////////////////////////////////////////////
99+
#endif // not APSTUDIO_INVOKED
100+

windows/ReactNativePicker/ReactNativePicker.vcxproj

+7-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@
7070
<LinkIncremental>false</LinkIncremental>
7171
</PropertyGroup>
7272
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
73-
<ImportGroup Label="ExtensionSettings"></ImportGroup>
73+
<ImportGroup Label="ExtensionSettings">
74+
</ImportGroup>
7475
<ImportGroup Label="PropertySheets">
7576
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
7677
</ImportGroup>
@@ -118,6 +119,7 @@
118119
<DependentUpon>ReactPackageProvider.idl</DependentUpon>
119120
</ClInclude>
120121
<ClInclude Include="pch.h" />
122+
<ClInclude Include="resource.h" />
121123
</ItemGroup>
122124
<ItemGroup>
123125
<ClCompile Include="ReactPickerView.cpp">
@@ -141,6 +143,9 @@
141143
<None Include="ReactNativePicker.def" />
142144
<None Include="PropertySheet.props" />
143145
</ItemGroup>
146+
<ItemGroup>
147+
<ResourceCompile Include="ReactNativePicker.rc" />
148+
</ItemGroup>
144149
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
145150
<ImportGroup Label="ReactNativeWindowsTargets">
146151
<Import Project="$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppLib.targets" Condition="Exists('$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppLib.targets')" />
@@ -164,4 +169,4 @@
164169
<Error Condition="!Exists('$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.210312.4\build\native\Microsoft.Windows.CppWinRT.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.210312.4\build\native\Microsoft.Windows.CppWinRT.targets'))" />
165170
<Error Condition="!Exists('$(SolutionDir)\packages\$(WinUIPackageName).$(WinUIPackageVersion)\build\native\$(WinUIPackageName).targets')" Text="$([System.String]::Format('$(ErrorText)', '$(SolutionDir)\packages\$(WinUIPackageName).$(WinUIPackageVersion)\build\native\$(WinUIPackageName).targets'))" />
166171
</Target>
167-
</Project>
172+
</Project>

windows/ReactNativePicker/Reactnativepicker.vcxproj.filters

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<ItemGroup>
4-
<Midl Include="ReactPackageProvider.idl" />
4+
<Midl Include="ReactPackageProvider.idl" />
5+
<Midl Include="ReactPickerView.idl" />
56
</ItemGroup>
67
<ItemGroup>
78
<ClCompile Include="pch.cpp" />
@@ -13,9 +14,14 @@
1314
<ClInclude Include="pch.h" />
1415
<ClInclude Include="ReactPackageProvider.h" />
1516
<ClInclude Include="ReactPickerViewManager.h" />
17+
<ClInclude Include="resource.h" />
1618
</ItemGroup>
1719
<ItemGroup>
1820
<None Include="PropertySheet.props" />
1921
<None Include="packages.config" />
22+
<None Include="ReactNativePicker.def" />
23+
</ItemGroup>
24+
<ItemGroup>
25+
<ResourceCompile Include="ReactNativePicker.rc" />
2026
</ItemGroup>
2127
</Project>

windows/ReactNativePicker/resource.h

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
//{{NO_DEPENDENCIES}}
2+
// Microsoft Visual C++ generated include file.
3+
// Used by ReactNativePicker.rc
4+
5+
// Next default values for new objects
6+
//
7+
#ifdef APSTUDIO_INVOKED
8+
#ifndef APSTUDIO_READONLY_SYMBOLS
9+
#define _APS_NEXT_RESOURCE_VALUE 101
10+
#define _APS_NEXT_COMMAND_VALUE 40001
11+
#define _APS_NEXT_CONTROL_VALUE 1001
12+
#define _APS_NEXT_SYMED_VALUE 101
13+
#endif
14+
#endif

0 commit comments

Comments
 (0)