Make AppRegistry and Core timers Flow strict-local (#57735)

Summary:
Pull Request resolved: #57735

Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D113763781

Author: rubennorte

packages/react-native/Libraries/Core/Timers/immediateShim.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  * @deprecated
  */
@@ -22,7 +22,10 @@ const clearedImmediates: Set<number> = new Set();
  * @param {function} func Callback to be invoked before the end of the
  * current JavaScript execution loop.
  */
-export function setImmediate(callback: Function, ...args: any): number {
+export function setImmediate<TArgs extends Array<unknown>>(
+  callback: (...args: TArgs) => unknown,
+  ...args: TArgs
+): number {
   if (arguments.length < 1) {
     throw new TypeError(
       'setImmediate must be called with at least one argument (a function to call)',
@@ -41,7 +44,6 @@ export function setImmediate(callback: Function, ...args: any): number {
     clearedImmediates.delete(id);
   }
 
-  // $FlowFixMe[incompatible-type]
   global.queueMicrotask(() => {
     if (!clearedImmediates.has(id)) {
       callback.apply(undefined, args);

packages/react-native/Libraries/Core/Timers/queueMicrotask.js

@@ -4,13 +4,13 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
 'use strict';
 
-let resolvedPromise;
+let resolvedPromise: ?Promise<void>;
 
 /**
  * Polyfill for the microtask queueing API defined by WHATWG HTML spec.
@@ -19,7 +19,7 @@ let resolvedPromise;
  * The method must queue a microtask to invoke @param {function} callback, and
  * if the callback throws an exception, report the exception.
  */
-export default function queueMicrotask(callback: Function) {
+export default function queueMicrotask(callback: () => unknown) {
   if (arguments.length < 1) {
     throw new TypeError(
       'queueMicrotask must be called with at least one argument (a function to call)',
@@ -30,7 +30,6 @@ export default function queueMicrotask(callback: Function) {
   }
 
   // Try to reuse a lazily allocated resolved promise from closure.
-  // $FlowFixMe[constant-condition]
   (resolvedPromise || (resolvedPromise = Promise.resolve()))
     .then(callback)
     .catch(error =>

packages/react-native/Libraries/ReactNative/AppRegistry.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 

packages/react-native/Libraries/ReactNative/AppRegistry.js.flow

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 

packages/react-native/Libraries/ReactNative/AppRegistryImpl.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -113,7 +113,7 @@ export function registerComponent(
       displayMode,
     });
   };
-  if (section) {
+  if (section === true) {
     sections[appKey] = runnables[appKey];
   }
   return appKey;
@@ -220,7 +220,7 @@ export function runApplication(
  */
 export function setSurfaceProps(
   appKey: string,
-  appParameters: Object,
+  appParameters: AppParameters,
   displayMode?: number,
 ): void {
   if (appKey !== 'LogBox') {
@@ -264,7 +264,6 @@ export function registerHeadlessTask(
   taskKey: string,
   taskProvider: TaskProvider,
 ): void {
-  // $FlowFixMe[object-this-reference]
   registerCancellableHeadlessTask(taskKey, taskProvider, () => () => {
     /* Cancel is no-op */
   });
@@ -300,7 +299,7 @@ export function registerCancellableHeadlessTask(
 export function startHeadlessTask(
   taskId: number,
   taskKey: string,
-  data: any,
+  data: unknown,
 ): void {
   const NativeHeadlessJsTaskSupport =
     require('./NativeHeadlessJsTaskSupport').default;
@@ -326,8 +325,7 @@ export function startHeadlessTask(
         NativeHeadlessJsTaskSupport &&
         reason instanceof HeadlessJsTaskError
       ) {
-        // $FlowFixMe[unused-promise]
-        NativeHeadlessJsTaskSupport.notifyTaskRetry(taskId).then(
+        void NativeHeadlessJsTaskSupport.notifyTaskRetry(taskId).then(
           retryPosted => {
             if (!retryPosted) {
               NativeHeadlessJsTaskSupport.notifyTaskFinished(taskId);

packages/react-native/ReactNativeApi.d.ts

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<25a1cb3522d4ccc914779c118a0747fe>>
+ * @generated SignedSource<<cf6a759b9ae1a69151a61e1babd1abd3>>
  *
  * This file was generated by scripts/js-api/build-types/index.js.
  */
@@ -4483,7 +4483,7 @@ declare type setStyleAttributePreprocessor =
   typeof setStyleAttributePreprocessor
 declare function setSurfaceProps(
   appKey: string,
-  appParameters: Object,
+  appParameters: AppParameters,
   displayMode?: number,
 ): void
 declare type Settings = typeof Settings
@@ -4698,7 +4698,7 @@ declare type stagger = typeof stagger
 declare function startHeadlessTask(
   taskId: number,
   taskKey: string,
-  data: any,
+  data: unknown,
 ): void
 declare type State = {
   cellsAroundViewport: {
@@ -5758,7 +5758,7 @@ export {
   AndroidKeyboardEvent, // e03becc8
   Animated, // b73ca27a
   AppConfig, // 35c0ca70
-  AppRegistry, // 5bc2bced
+  AppRegistry, // eb82174d
   AppState, // 12012be5
   AppStateEvent, // 80f034c3
   AppStateStatus, // 447e5ef2