Skip to content

Commit 5e9cce8

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover react/renderer/animationbackend with Stable API guards (#58304)
Summary: Pull Request resolved: #58304 Classifies `react/renderer/animationbackend:animationbackend` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. `React-Fabric` already depended on `React-cxxstableapi` from an earlier migration in the same pod, so the module's subspec needs no change. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D118616103 fbshipit-source-id: dbe574a524c8a29e204792ca2193c4c8238d1c20
1 parent fcbeda1 commit 5e9cce8

8 files changed

Lines changed: 17 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
*/
77

88
#pragma once
9+
10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
912
#include <react/renderer/components/view/BaseViewProps.h>
1013

1114
#include <utility>

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
*/
77

88
#pragma once
9+
10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
912
#include <react/renderer/components/view/BaseViewProps.h>
1013
#include <react/renderer/graphics/Filter.h>
1114
#include "AnimatedProps.h"

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <folly/dynamic.h>
1113
#include <react/renderer/components/view/BaseViewProps.h>
1214
#include <react/renderer/core/ReactPrimitives.h>

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsSerializer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <folly/dynamic.h>
1113
#include "AnimatedProps.h"
1214

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <ReactCommon/CallInvoker.h>
1113
#include <react/renderer/core/ReactPrimitives.h>
1214
#include <react/renderer/uimanager/UIManager.h>

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/core/ReactPrimitives.h>
1113
#include <react/renderer/uimanager/UIManager.h>
1214
#include <react/renderer/uimanager/UIManagerCommitHook.h>

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationChoreographer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/uimanager/UIManagerAnimationBackend.h>
1113
#include <react/timing/primitives.h>
1214

packages/react-native/ReactCommon/react/renderer/animationbackend/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ target_include_directories(react_renderer_animationbackend PUBLIC ${REACT_COMMON
1515

1616
target_link_libraries(react_renderer_animationbackend
1717
react_codegen_rncore
18+
react_cxxstableapi
1819
react_debug
1920
react_renderer_core
2021
react_renderer_graphics

0 commit comments

Comments
 (0)