Skip to content

Commit 79d9ffe

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover react/renderer/element with Stable API guards (#58178)
Summary: Pull Request resolved: #58178 Classifies `react/renderer/element:element` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's four exported headers (`Element.h`, `ElementFragment.h`, `ComponentBuilder.h`, `testUtils.h`), and wires the guard dependency into BUCK and CMake. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117837637 fbshipit-source-id: a06c77026eeaca8b66aaef1a70ae2d42d3f90ec8
1 parent 90b2ba5 commit 79d9ffe

5 files changed

Lines changed: 9 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/renderer/element/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ target_include_directories(react_renderer_element PUBLIC ${REACT_COMMON_DIR})
1616
target_link_libraries(react_renderer_element
1717
folly_runtime
1818
glog
19+
react_cxxstableapi
1920
react_renderer_core
2021
react_renderer_componentregistry
2122
)

packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <memory>
1113

1214
#include <react/renderer/componentregistry/ComponentDescriptorRegistry.h>

packages/react-native/ReactCommon/react/renderer/element/Element.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <functional>
1113
#include <memory>
1214

packages/react-native/ReactCommon/react/renderer/element/ElementFragment.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <functional>
1113
#include <memory>
1214
#include <vector>

packages/react-native/ReactCommon/react/renderer/element/testUtils.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
1113
#include <react/renderer/components/modal/ModalHostViewComponentDescriptor.h>
1214
#include <react/renderer/components/root/RootComponentDescriptor.h>

0 commit comments

Comments
 (0)