Skip to content

Commit a2d52c6

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Upgrade UIManager visibility to "for frameworks"
Summary: Reclassifies `react/renderer/uimanager:uimanager` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118275456
1 parent 4f003c4 commit a2d52c6

19 files changed

Lines changed: 15 additions & 69 deletions

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ val preparePrefab by
162162
Pair("../ReactCommon/react/renderer/scheduler/", "react/renderer/scheduler/"),
163163
// react_renderer_uimanager
164164
Pair("../ReactCommon/react/renderer/uimanager/", "react/renderer/uimanager/"),
165-
Pair("../ReactCommon/react/renderer/uimanager/React/", "React/"),
166165
// react_utils
167166
Pair("../ReactCommon/react/utils/", "react/utils/"),
168167
// rrc_image

packages/react-native/ReactCommon/React-Fabric.podspec

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -256,12 +256,6 @@ Pod::Spec.new do |s|
256256
ss.header_dir = "react/renderer/uimanager"
257257
end
258258

259-
s.subspec "uimanagerUmbrella" do |ss|
260-
ss.source_files = "react/renderer/uimanager/React/*.h"
261-
ss.header_dir = "React"
262-
ss.header_mappings_dir = "react/renderer/uimanager/React"
263-
end
264-
265259
s.subspec "leakchecker" do |ss|
266260
ss.source_files = podspec_sources("react/renderer/leakchecker/**/*.{cpp,h}", "react/renderer/leakchecker/**/*.h")
267261
ss.exclude_files = "react/renderer/leakchecker/tests"

packages/react-native/ReactCommon/react/renderer/uimanager/AppRegistryBinding.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <jsi/jsi.h>

packages/react-native/ReactCommon/react/renderer/uimanager/LayoutAnimationStatusDelegate.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
namespace facebook::react {
1313

packages/react-native/ReactCommon/react/renderer/uimanager/LayoutEventEmitter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/uimanager/UIManagerCommitHook.h>
1313

packages/react-native/ReactCommon/react/renderer/uimanager/PointerEventsProcessor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <functional>
1313

packages/react-native/ReactCommon/react/renderer/uimanager/PointerHoverTracker.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <functional>
1313
#include <initializer_list>

packages/react-native/ReactCommon/react/renderer/uimanager/React/UIManager.h

Lines changed: 0 additions & 41 deletions
This file was deleted.

packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <jsi/jsi.h>

packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerAnimationBackend.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <ReactCommon/CallInvoker.h>
1313
#include <react/renderer/core/ReactPrimitives.h>

0 commit comments

Comments
 (0)