Skip to content

Commit e04215a

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover react/renderer/animated with guards
Summary: Classifies `react/renderer/animated:animated` as a "for frameworks" target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/FrameworksGuard.h>` to the module's 30 non-test headers, and wires the guard dependency into BUCK and CMake. No CocoaPods change is needed: the module ships as a subspec of `React-Fabric`, whose parent spec already declares `React-cxxstableapi` and calls `mark_as_react_native_build`. Consumers that opt into `RN_STRICT_API` now get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118256232
1 parent 2fa37b1 commit e04215a

31 files changed

Lines changed: 62 additions & 0 deletions

packages/react-native/ReactCommon/react/renderer/animated/AnimatedModule.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
1113
#include "FBReactNativeSpecJSI.h"
1214
#else

packages/react-native/ReactCommon/react/renderer/animated/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ target_include_directories(react_renderer_animated PUBLIC ${REACT_COMMON_DIR})
2020

2121
target_link_libraries(react_renderer_animated
2222
react_codegen_rncore
23+
react_cxxstableapi
2324
react_debug
2425
react_renderer_core
2526
react_renderer_graphics

packages/react-native/ReactCommon/react/renderer/animated/EventEmitterListener.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <mutex>
1113
#include <shared_mutex>
1214

packages/react-native/ReactCommon/react/renderer/animated/MergedValueDispatcher.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <folly/dynamic.h>
1113
#include <react/renderer/core/ReactPrimitives.h>
1214
#include <functional>

packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManager.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
1113
#include "FBReactNativeSpecJSI.h"
1214
#else

packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManagerProvider.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/animated/MergedValueDispatcher.h>
1113
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
1214
#include "NativeAnimatedNodesManager.h"

packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriver.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/FrameworksGuard.h>
9+
810
/*
911
* Adapted from react-native-windows under the MIT license.
1012
*/

packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriverUtils.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/FrameworksGuard.h>
9+
810
/*
911
* Adapted from react-native-windows under the MIT license.
1012
*/

packages/react-native/ReactCommon/react/renderer/animated/drivers/DecayAnimationDriver.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/FrameworksGuard.h>
9+
810
/*
911
* Adapted from react-native-windows under the MIT license.
1012
*/

packages/react-native/ReactCommon/react/renderer/animated/drivers/FrameAnimationDriver.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/FrameworksGuard.h>
9+
810
/*
911
* Adapted from react-native-windows under the MIT license.
1012
*/

0 commit comments

Comments
 (0)