Skip to content

[RN][iOS] Set RN version before building binaries in Release - #53636

Draft
cipolleschi wants to merge 5 commits into
mainfrom
cipolleschi/fix-version-in-prebuilds
Draft

[RN][iOS] Set RN version before building binaries in Release#53636
cipolleschi wants to merge 5 commits into
mainfrom
cipolleschi/fix-version-in-prebuilds

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Summary:

The template app is failing because we have a check where the native version and the js version of react native do not match.

This is happening with prebuilds but not with building from source, because when the prebuilts has been built, the version of React Native was still 1000.0.0 while when we build the app, the app sees the right RC version.

This change attempts to fix the issue by setting the native versions before building the binaries, so that they are aligned with the varion we are actually building.

Changelog:

[Internal] -

Test Plan:

na

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2025
@cipolleschi cipolleschi changed the title cipolleschi/fix version in prebuilds [RN][iOS] Set RN version before building binaries in Release Sep 8, 2025
@react-native-bot

react-native-bot commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

Warnings
⚠️ ❗ JavaScript API change detected - This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API. Please include a clear changelog message. This change will be subject to extra review.

This change was flagged as: BREAKING

Generated by 🚫 dangerJS against 1767cf5

@cipolleschi
cipolleschi force-pushed the cipolleschi/fix-version-in-prebuilds branch from f2b18fa to 1767cf5 Compare September 8, 2025 12:56
@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Mar 8, 2026
@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Stale There has been a lack of activity on this issue and it may be closed soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants