Skip to content

Commit 9fbdb1e

Browse files
ellemac123meta-codesync[bot]
ellemac123
authored and
meta-codesync[bot]
committed
Remove disabled intrinsic-sizing test cases (#2001)
Summary: Pull Request resolved: #2001 Removes the disabled (`data-disabled`) intrinsic-sizing test cases from the gentest fixtures and their generated Java/C++/JS tests. These cases (fit-content / max-content / stretch, several gated behind the `FixFlexBasisFitContent` experiment) were checked in disabled because Yoga's layout does not yet match the browser reference for them, so they only ever produce skipped tests. Remove them for now; re-add and enable once the behavior is implemented. Also removes the now-orphaned TODO comments that annotated those cases. Reviewed By: GijsWeterings, cortinico Differential Revision: D113528568 fbshipit-source-id: d3ce19f2cd5eb994170cf7d3995d9748212b55c9
1 parent 6b31667 commit 9fbdb1e

40 files changed

Lines changed: 47 additions & 10548 deletions

‎gentest/fixtures/YGAlignItemsTest.html‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -117,32 +117,6 @@
117117
<div style="width: 50px; height: 50px;"></div>
118118
</div>
119119

120-
<!-- TODO: Yoga's behavior is no longer in line with Chromium -->
121-
<div id="align_baseline_multiline_column" data-disabled="true"
122-
style="width: 100px; height: 100px; flex-direction:column; align-items: baseline;flex-wrap:wrap;">
123-
<div style="width: 50px; height: 50px;"></div>
124-
<div style="width: 30px; height: 50px;">
125-
<div style="width: 20px; height: 20px;"></div>
126-
</div>
127-
<div style="width: 40px; height: 70px;">
128-
<div style="width: 10px; height: 10px;"></div>
129-
</div>
130-
<div style="width: 50px; height: 20px;"></div>
131-
</div>
132-
133-
<!-- TODO: Yoga's behavior is no longer in line with Chromium -->
134-
<div id="align_baseline_multiline_column2" data-disabled="true"
135-
style="width: 100px; height: 100px; flex-direction:column; align-items: baseline;flex-wrap:wrap;">
136-
<div style="width: 50px; height: 50px;flex-direction:column;"></div>
137-
<div style="width: 30px; height: 50px;flex-direction:column;">
138-
<div style="width: 20px; height: 20px;flex-direction:column;"></div>
139-
</div>
140-
<div style="width: 40px; height: 70px;flex-direction:column;">
141-
<div style="width: 10px; height: 10px;flex-direction:column;"></div>
142-
</div>
143-
<div style="width: 50px; height: 20px;flex-direction:column;"></div>
144-
</div>
145-
146120
<div id="align_baseline_multiline_row_and_column"
147121
style="width: 100px; height: 100px; flex-direction:row; align-items: baseline;flex-wrap:wrap;">
148122
<div style="width: 50px; height: 50px;"></div>

‎gentest/fixtures/YGAspectRatioTest.html‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,3 @@
1-
<!-- TODO: aspect-ratio behavior is inconsistent with Web -->
2-
<div id="aspect_ratio_does_not_stretch_cross_axis_dim" data-disabled="true" style="width: 300px; height: 300px;">
3-
<div style="flex: 1; overflow: scroll;">
4-
<div style="flex-direction: row;">
5-
<div style="flex: 2; aspect-ratio: 1;"></div>
6-
<div style="width: 5px"></div>
7-
<div style="flex: 1">
8-
<div style="flex: 1; aspect-ratio: 1;">
9-
<div style="width: 5px"></div>
10-
<div style="flex: 1; aspect-ratio: 1;"></div>
11-
</div>
12-
</div>
13-
</div>
14-
</div>
15-
</div>
16-
171
<div id="zero_aspect_ratio_behaves_like_auto" style="width: 300px; height: 300px;">
182
<div style="aspect-ratio: 0; width: 50px"></div>
193
</div>

‎gentest/fixtures/YGBoxSizingTest.html‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -197,23 +197,11 @@
197197
</div>
198198
</div>
199199

200-
<div data-disabled="true" id="box_sizing_content_box_flex_basis_row"
201-
style="width: 100px; height: 100px; flex-direction: row;">
202-
<div style="flex-basis: 50px; height: 25px; padding: 5px; border-width: 10px; box-sizing: content-box">
203-
</div>
204-
</div>
205-
206200
<div id="box_sizing_border_box_flex_basis_row" style="width: 100px; height: 100px; flex-direction: row;">
207201
<div style="flex-basis: 50px; height: 25px; padding: 5px; border-width: 10px; box-sizing: border-box">
208202
</div>
209203
</div>
210204

211-
<div data-disabled="true" id="box_sizing_content_box_flex_basis_column"
212-
style="width: 100px; height: 100px; flex-direction: column;">
213-
<div style="flex-basis: 50px; height: 25px; padding: 5px; border-width: 10px; box-sizing: content-box">
214-
</div>
215-
</div>
216-
217205
<div id="box_sizing_border_box_flex_basis_column" style="width: 100px; height: 100px; flex-direction: column;">
218206
<div style="flex-basis: 50px; height: 25px; padding: 5px; border-width: 10px; box-sizing: border-box">
219207
</div>

‎gentest/fixtures/YGFlexDirectionTest.html‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -241,22 +241,6 @@
241241
</div>
242242
</div>
243243

244-
<div id="flex_direction_row_reverse_inner_pos_start" data-disabled="true" style="height: 100px; width: 100px;">
245-
<div style="height: 100px; width: 100px; flex-direction: row-reverse; ">
246-
<div style="width: 10px; height: 10px; position: absolute; inset-inline-start: 10px"></div>
247-
<div style="width: 10px;"></div>
248-
<div style="width: 10px;"></div>
249-
</div>
250-
</div>
251-
252-
<div id="flex_direction_row_reverse_inner_pos_end" data-disabled="true" style="height: 100px; width: 100px;">
253-
<div style="height: 100px; width: 100px; flex-direction: row-reverse; ">
254-
<div style="width: 10px; height: 10px; position: absolute; inset-inline-end: 10px"></div>
255-
<div style="width: 10px;"></div>
256-
<div style="width: 10px;"></div>
257-
</div>
258-
</div>
259-
260244
<div id="flex_direction_row_reverse_inner_margin_left" style="height: 100px; width: 100px;">
261245
<div style="height: 100px; width: 100px; flex-direction: row-reverse; ">
262246
<div style="width: 10px; height: 10px; position: absolute; margin-left: 10px"></div>

‎gentest/fixtures/YGFlexWrapTest.html‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
<div data-disabled="true" id="wrap_column" style="height: 100px; flex-wrap: wrap">
2-
<div style="height: 30px; width: 30px;"></div>
3-
<div style="height: 30px; width: 30px;"></div>
4-
<div style="height: 30px; width: 30px;"></div>
5-
<div style="height: 30px; width: 30px;"></div>
6-
</div>
7-
81
<div id="wrap_row" style="width: 100px; flex-direction: row; flex-wrap: wrap">
92
<div style="height: 30px; width: 30px;"></div>
103
<div style="height: 30px; width: 30px;"></div>

‎gentest/fixtures/YGGapTest.html‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,3 @@
231231
<div style="flex: 1;"></div>
232232
<div style="width: 10%;"></div>
233233
</div>
234-
235-
<!-- TODO: Existing bug that Yoga is not inline with Chromium for calculation with min-width -->
236-
<div id="row_gap_percent_wrapping_with_min_width" data-disabled="true" style="flex-direction: row; min-width: 300px; gap: 10%; flex-wrap: wrap;">
237-
<div style="width: 100px; height: 100px;"></div>
238-
<div style="width: 100px; height: 100px;"></div>
239-
<div style="width: 100px; height: 100px;"></div>
240-
<div style="width: 100px; height: 100px;"></div>
241-
<div style="width: 100px; height: 100px;"></div>
242-
</div>

0 commit comments

Comments
 (0)