Working command deploy script

Author: vcarl

scripts/deploy-commands.ts

@@ -3,16 +3,26 @@ import {
   SlashCommandBuilder,
 } from "@discordjs/builders";
 import { REST } from "@discordjs/rest";
-import { ApplicationCommandType, Routes } from "discord-api-types/v9";
+import {
+  APIApplicationCommand,
+  ApplicationCommandType,
+  Routes,
+} from "discord-api-types/v9";
 import { applicationId, discordToken, guildId } from "../src/constants";
 import { logger } from "../src/features/log";
+import { difference } from "../src/helpers/sets";
 
-const cmd = {
-  name: "test action",
-  description: "¡some kind of test action!",
-  handler: () => {},
-};
-const cmds = [cmd];
+// TODO: make this a global command in production
+const upsertUrl = () => Routes.applicationGuildCommands(applicationId, guildId);
+const deleteUrl = (commandId: string) =>
+  Routes.applicationGuildCommand(applicationId, guildId, commandId);
+
+interface CommandConfig {
+  name: string;
+  description: string;
+  type: ApplicationCommandType;
+}
+const cmds: CommandConfig[] = [];
 
 const commands = [
   ...cmds
@@ -44,15 +54,68 @@ const commands = [
         .toJSON(),
     ),
 ];
+const names = new Set(commands.map((c) => c.name));
 
 const rest = new REST({ version: "9" }).setToken(discordToken);
+const deploy = async () => {
+  const remoteCommands = (await rest.get(
+    upsertUrl(),
+  )) as APIApplicationCommand[];
+
+  // Take the list of names to delete and swap it out for IDs to delete
+  const remoteNames = new Set(remoteCommands.map((c) => c.name));
+  const deleteNames = [...difference(remoteNames, names)];
+  const toDelete = deleteNames
+    .map((x) => remoteCommands.find((y) => y.name === x)?.id)
+    .filter((x): x is string => Boolean(x));
 
-rest
-  // TODO: make this a global command in production
-  .put(Routes.applicationGuildCommands(applicationId, guildId), {
-    body: commands,
-  })
-  .then(() =>
-    logger.log("DEPLOY", "Successfully registered application commands."),
-  )
-  .catch((e) => logger.log("DEPLOY", e));
+  logger.log(
+    "DEPLOY",
+    `Removing ${toDelete.length} commands: [${deleteNames.join(",")}]`,
+  );
+  await Promise.allSettled(
+    toDelete.map((commandId) => rest.delete(deleteUrl(commandId))),
+  );
+
+  // Grab a list of commands that need to be updated
+  const toUpdate = remoteCommands.filter(
+    (c) =>
+      // Check all necessary fields to see if any changed. User and Message
+      // commands don't have a description.
+      !commands.find((x) => {
+        const {
+          type = ApplicationCommandType.ChatInput,
+          name,
+          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+          // @ts-expect-error Unions are weird
+          description = "",
+        } = x;
+        switch (type as ApplicationCommandType) {
+          case ApplicationCommandType.User:
+          case ApplicationCommandType.Message:
+            return name === c.name && type === c.type;
+          case ApplicationCommandType.ChatInput:
+          default:
+            return (
+              name === c.name &&
+              type === c.type &&
+              description === c.description
+            );
+        }
+      }),
+  );
+
+  logger.log(
+    "DEPLOY",
+    `Updating ${toUpdate.length} commands: [${toUpdate
+      .map((x) => x.name)
+      .join(",")}]`,
+  );
+
+  await rest.put(upsertUrl(), { body: commands });
+};
+try {
+  deploy();
+} catch (e) {
+  logger.log("DEPLOY EXCEPTION", e as string);
+}

src/helpers/sets.ts

@@ -0,0 +1,2 @@
+export const difference = <T>(a: Set<T>, b: Set<T>) =>
+  new Set(Array.from(a).filter((x) => !b.has(x)));