Skip to content

Commit 1e349c0

Browse files
manuhabiteladiasbruno
authored andcommitted
[fixed] remove aria-modal attr to prevent browser bugs
There were a couple problems with the aria-modal attribute: - it was not set on the correct dom element (in theory, it should be set on the element having the dialog role, as stated in #654) - it is buggy in Safari. The easy way to fix the problem is to remove the attribute (again, as suggested in #654). While it's cool on paper, the attribute is currently not necessary, since the `aria-hidden="true"` is set correctly on the app element.
1 parent 4377cc8 commit 1e349c0

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: src/components/ModalPortal.js

-1
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,6 @@ export default class ModalPortal extends Component {
334334
style={{ ...overlayStyles, ...this.props.style.overlay }}
335335
onClick={this.handleOverlayOnClick}
336336
onMouseDown={this.handleOverlayOnMouseDown}
337-
aria-modal="true"
338337
>
339338
<div
340339
ref={this.setContentRef}

0 commit comments

Comments
 (0)