Skip to content

Commit 2132488

Browse files
Hypnosphidiasbruno
authored andcommitted
Add eslint rule to disallow importing devDependencies in lib sources
1 parent 4887c69 commit 2132488

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

Diff for: .eslintrc.js

+8-3
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,11 @@ module.exports = {
2020
"pragma": "React",
2121
"version": "15.0"
2222
},
23-
"propWrapperFunctions": [ "forbidExtraProps" ]
23+
"propWrapperFunctions": [ "forbidExtraProps" ],
24+
"import/resolver": "webpack"
2425
},
2526

26-
"extends": ["eslint:recommended", "plugin:react/recommended", "prettier"],
27+
"extends": ["eslint:recommended", "plugin:react/recommended", "plugin:import/recommended", "prettier"],
2728

2829
"plugins": ["prettier"],
2930

@@ -45,6 +46,10 @@ module.exports = {
4546
"prettier/prettier": "error",
4647
"react/no-find-dom-node": [0],
4748
"react/jsx-closing-bracket-location": [0],
48-
"react/require-default-props": 0
49+
"react/require-default-props": 0,
50+
"import/no-extraneous-dependencies": [2, {
51+
"devDependencies": ["specs/**"]
52+
}]
4953
}
54+
5055
}

Diff for: package.json

+2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@
3434
"cross-env": "^5.0.1",
3535
"eslint": "^4.8.0",
3636
"eslint-config-prettier": "^2.6.0",
37+
"eslint-import-resolver-webpack": "^0.9.0",
38+
"eslint-plugin-import": "^2.10.0",
3739
"eslint-plugin-jsx-a11y": "^6.0.2",
3840
"eslint-plugin-prettier": "^2.3.1",
3941
"eslint-plugin-react": "^7.4.0",

0 commit comments

Comments
 (0)