Skip to content

Commit 86987d5

Browse files
committed
Use create-react-class to avoid React.createClass deprecations
fixes #367
1 parent 16efd72 commit 86987d5

File tree

4 files changed

+17
-15
lines changed

4 files changed

+17
-15
lines changed

Diff for: lib/components/Modal.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ var refCount = require('../helpers/refCount');
88
var elementClass = require('element-class');
99
var renderSubtreeIntoContainer = require("react-dom").unstable_renderSubtreeIntoContainer;
1010
var Assign = require('lodash.assign');
11+
var createReactClass = require('create-react-class')
1112

1213
var SafeHTMLElement = ExecutionEnvironment.canUseDOM ? window.HTMLElement : {};
1314
var AppElement = ExecutionEnvironment.canUseDOM ? document.body : {appendChild: function() {}};
@@ -16,7 +17,7 @@ function getParentElement(parentSelector) {
1617
return parentSelector();
1718
}
1819

19-
var Modal = React.createClass({
20+
var Modal = createReactClass({
2021

2122
displayName: 'Modal',
2223
statics: {

Diff for: lib/components/ModalPortal.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ var div = React.DOM.div;
33
var focusManager = require('../helpers/focusManager');
44
var scopeTab = require('../helpers/scopeTab');
55
var Assign = require('lodash.assign');
6+
var createReactClass = require('create-react-class');
67

78
// so that our CSS is statically analyzable
89
var CLASS_NAMES = {
@@ -18,7 +19,7 @@ var CLASS_NAMES = {
1819
}
1920
};
2021

21-
var ModalPortal = module.exports = React.createClass({
22+
var ModalPortal = module.exports = createReactClass({
2223

2324
displayName: 'ModalPortal',
2425
shouldClose: null,

Diff for: package.json

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"webpack-dev-server": "1.11.0"
5757
},
5858
"dependencies": {
59+
"create-react-class": "^15.5.2",
5960
"element-class": "^0.2.0",
6061
"exenv": "1.2.0",
6162
"lodash.assign": "^4.2.0",

Diff for: yarn.lock

+12-13
Original file line numberDiff line numberDiff line change
@@ -1087,6 +1087,13 @@ core-util-is@~1.0.0:
10871087
version "1.0.2"
10881088
resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7"
10891089

1090+
create-react-class@^15.5.2:
1091+
version "15.5.2"
1092+
resolved "https://registry.yarnpkg.com/create-react-class/-/create-react-class-15.5.2.tgz#6a8758348df660b88326a0e764d569f274aad681"
1093+
dependencies:
1094+
fbjs "^0.8.9"
1095+
object-assign "^4.1.1"
1096+
10901097
cross-spawn@^4.0.0:
10911098
version "4.0.2"
10921099
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-4.0.2.tgz#7b9247621c23adfdd3856004a823cbe397424d41"
@@ -1563,19 +1570,7 @@ [email protected]:
15631570
version "0.1.8"
15641571
resolved "https://registry.yarnpkg.com/eyes/-/eyes-0.1.8.tgz#62cf120234c683785d902348a800ef3e0cc20bc0"
15651572

1566-
fbjs@^0.8.1, fbjs@^0.8.4:
1567-
version "0.8.8"
1568-
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.8.tgz#02f1b6e0ea0d46c24e0b51a2d24df069563a5ad6"
1569-
dependencies:
1570-
core-js "^1.0.0"
1571-
isomorphic-fetch "^2.1.1"
1572-
loose-envify "^1.0.0"
1573-
object-assign "^4.1.0"
1574-
promise "^7.1.1"
1575-
setimmediate "^1.0.5"
1576-
ua-parser-js "^0.7.9"
1577-
1578-
fbjs@^0.8.9:
1573+
fbjs@^0.8.1, fbjs@^0.8.4, fbjs@^0.8.9:
15791574
version "0.8.12"
15801575
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.12.tgz#10b5d92f76d45575fd63a217d4ea02bea2f8ed04"
15811576
dependencies:
@@ -3202,6 +3197,10 @@ object-assign@^4.0.1, object-assign@^4.1.0:
32023197
version "4.1.0"
32033198
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.0.tgz#7a3b3d0e98063d43f4c03f2e8ae6cd51a86883a0"
32043199

3200+
object-assign@^4.1.1:
3201+
version "4.1.1"
3202+
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863"
3203+
32053204
32063205
version "0.0.3"
32073206
resolved "https://registry.yarnpkg.com/object-component/-/object-component-0.0.3.tgz#f0c69aa50efc95b866c186f400a33769cb2f1291"

0 commit comments

Comments
 (0)