Skip to content

Commit aa66819

Browse files
committed
[fixed] Removes unneeded sanitizeProps function (#169)
fixes #165 The sanitize props function seems to be unneeded and there is no concrete explanation for why it is there. This removes it to prevent problems caused by calling it.
1 parent c55d6b4 commit aa66819

File tree

2 files changed

+1
-58
lines changed

2 files changed

+1
-58
lines changed

Diff for: examples/basic/app.js

+1-53
Original file line numberDiff line numberDiff line change
@@ -6,46 +6,16 @@ var appElement = document.getElementById('example');
66

77
Modal.setAppElement('#example');
88

9-
Modal.defaultStyles = {
10-
overlay : {
11-
position : 'fixed',
12-
top : 0,
13-
left : 0,
14-
right : 0,
15-
bottom : 0,
16-
backgroundColor : 'rebeccapurple'
17-
},
18-
content : {
19-
position : 'absolute',
20-
top : '40px',
21-
left : '40px',
22-
right : '40px',
23-
bottom : '40px',
24-
border : '1px solid #ccc',
25-
background : '#fff',
26-
overflow : 'auto',
27-
WebkitOverflowScrolling : 'touch',
28-
borderRadius : '4px',
29-
outline : 'none',
30-
padding : '20px'
31-
32-
}
33-
}
34-
359
var App = React.createClass({
3610

3711
getInitialState: function() {
38-
return { modalIsOpen: false, modalIsOpen2: false };
12+
return { modalIsOpen: false };
3913
},
4014

4115
openModal: function() {
4216
this.setState({modalIsOpen: true});
4317
},
4418

45-
openModal2: function() {
46-
this.setState({modalIsOpen2: true});
47-
},
48-
4919
closeModal: function() {
5020
this.setState({modalIsOpen: false});
5121
},
@@ -69,7 +39,6 @@ var App = React.createClass({
6939
return (
7040
<div>
7141
<button onClick={this.openModal}>Open Modal</button>
72-
<button onClick={this.openModal2}>Open Modal 2</button>
7342
<Modal
7443
ref="mymodal"
7544
closeTimeoutMS={150}
@@ -92,27 +61,6 @@ var App = React.createClass({
9261
<button>hi</button>
9362
</form>
9463
</Modal>
95-
<Modal
96-
closeTimeoutMS={150}
97-
isOpen={this.state.modalIsOpen2}
98-
onRequestClose={this.handleModalCloseRequest}
99-
>
100-
<h1>Hello</h1>
101-
<button onClick={this.closeModal}>close</button>
102-
<div>I am a modal</div>
103-
<form>
104-
<input onChange={this.handleInputChange} />
105-
<input />
106-
<input />
107-
<input />
108-
<input />
109-
<br/>
110-
<button>hi</button>
111-
<button>hi</button>
112-
<button>hi</button>
113-
<button>hi</button>
114-
</form>
115-
</Modal>
11664
</div>
11765
);
11866
}

Diff for: lib/components/Modal.js

-5
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ var Modal = React.createClass({
5555
},
5656

5757
componentWillReceiveProps: function(newProps) {
58-
sanitizeProps(newProps);
5958
this.renderPortal(newProps);
6059
},
6160

@@ -110,7 +109,3 @@ Modal.defaultStyles = {
110109
}
111110

112111
module.exports = Modal
113-
114-
function sanitizeProps(props) {
115-
delete props.ref;
116-
}

0 commit comments

Comments
 (0)