Skip to content

Commit e56c414

Browse files
Ives van Hoornediasbruno
Ives van Hoorne
authored andcommitted
[chore] Return null for portal when modal is closed
1 parent 55920f9 commit e56c414

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Diff for: specs/Modal.spec.js

+5
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ describe('State', () => {
3030
expect(ReactDOM.findDOMNode(mcontent(modal))).toNotExist();
3131
});
3232

33+
it('doesn\'t render the portal if modal is closed', () => {
34+
const modal = renderModal({}, 'hello');
35+
expect(ReactDOM.findDOMNode(modal.portal)).toNotExist();
36+
})
37+
3338
it('has default props', () => {
3439
const node = document.createElement('div');
3540
Modal.setAppElement(document.createElement('div'));

Diff for: src/components/ModalPortal.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ export default class ModalPortal extends Component {
265265
const contentStyles = className ? {} : defaultStyles.content;
266266
const overlayStyles = overlayClassName ? {} : defaultStyles.overlay;
267267

268-
return this.shouldBeClosed() ? <div /> : (
268+
return this.shouldBeClosed() ? null : (
269269
<div
270270
ref={this.setOverlayRef}
271271
className={this.buildClassName('overlay', overlayClassName)}

0 commit comments

Comments
 (0)