Skip to content

Commit e5a80d6

Browse files
gnoffdiasbruno
authored andcommitted
[fixed] portal node will be reparented if necessary on props change
1 parent f715a69 commit e5a80d6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: src/components/Modal.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -134,15 +134,15 @@ class Modal extends Component {
134134
this.node.className = portalClassName;
135135
}
136136

137-
// Stop unnecessary renders if modal is remaining closed
138-
if (!prevProps.isOpen && !isOpen) return;
139-
140137
const { prevParent, nextParent } = snapshot;
141138
if (nextParent !== prevParent) {
142139
prevParent.removeChild(this.node);
143140
nextParent.appendChild(this.node);
144141
}
145142

143+
// Stop unnecessary renders if modal is remaining closed
144+
if (!prevProps.isOpen && !isOpen) return;
145+
146146
!isReact16 && this.renderPortal(this.props);
147147
}
148148

0 commit comments

Comments
 (0)