Skip to content

PrematureCloseException root exception is not logged in netty5 branch. #2938

@pderop

Description

@pderop

The PR #2937 that has been merged into the netty5 branch is not operational (only in netty5 branch).
It needs to be completed with another PR, and for the moment, the HttpServerTests.testIssue2927_H2C and HttpServerTests.testIssue2927 tests are disabled (in netty5 branch).

The problem in netty5 is that when the HeaderListSizeException is thrown, then:

  1. First, the HttpClientOperations.onInboundClose() is invoked -> here, no unprocessedOutboundError, so the PrematureCloseException is logged without the root cause exception.
  2. And right after, the ChannelOperations.onError(Throwable t) method is called .. but this too late, because the HttpClientOperations.onInboundClose() method has already logged the PrematureCloseExeption without the HeaderListSizeException root cause exception.

Expected Behavior

HttpServerTests.testIssue2927_H2C and HttpServerTests.testIssue2927 are not passing in netty5 branch, and they are currently disabled.

Actual Behavior

The HttpClientOperations.onInboundClose() is invoked before the ChannelOperations.onError(Throwable t) , so we log the PrematureCloseException without the HeaderListSizeException root cause exception

Steps to Reproduce

Possible Solution

Your Environment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions