Merge pull request #210 from readium/resolve-gutter-scroll

Only apply pageGutter in columns

Author: JayPanoz

css/dist/ReadiumCSS-after.css

@@ -71,11 +71,14 @@
 body{
   width:100%;
   max-width:var(--RS__defaultLineLength) !important;
-  padding:0 var(--RS__pageGutter) !important;
   margin:0 auto !important;
   box-sizing:border-box;
 }
 
+:root:not([style*="readium-scroll-on"]) body{
+  padding:0 var(--RS__pageGutter) !important;
+}
+
 :root:not([style*="readium-noOverflow-on"]) body{
   overflow:hidden;
 }

css/dist/cjk-horizontal/ReadiumCSS-after.css

@@ -71,11 +71,14 @@
 body{
   width:100%;
   max-width:var(--RS__defaultLineLength) !important;
-  padding:0 var(--RS__pageGutter) !important;
   margin:0 auto !important;
   box-sizing:border-box;
 }
 
+:root:not([style*="readium-scroll-on"]) body{
+  padding:0 var(--RS__pageGutter) !important;
+}
+
 :root:not([style*="readium-noOverflow-on"]) body{
   overflow:hidden;
 }

css/dist/cjk-vertical/ReadiumCSS-after.css

@@ -82,11 +82,14 @@
 body{
   width:100%;
   max-height:var(--RS__defaultLineLength) !important;
-  padding:var(--RS__pageGutter) 0 !important;
   margin:auto 0 !important;
   box-sizing:border-box;
 }
 
+:root:not([style*="readium-scroll-on"]) body{
+  padding:var(--RS__pageGutter) 0 !important;
+}
+
 :root:not([style*="readium-noOverflow-on"]) body{
   overflow:hidden;
 }

css/dist/rtl/ReadiumCSS-after.css

@@ -71,11 +71,14 @@
 body{
   width:100%;
   max-width:var(--RS__defaultLineLength) !important;
-  padding:0 var(--RS__pageGutter) !important;
   margin:0 auto !important;
   box-sizing:border-box;
 }
 
+:root:not([style*="readium-scroll-on"]) body{
+  padding:0 var(--RS__pageGutter) !important;
+}
+
 :root:not([style*="readium-noOverflow-on"]) body{
   overflow:hidden;
 }

css/src/modules/ReadiumCSS-pagination-vertical.css

@@ -94,6 +94,9 @@ body {
      Drawback: we have to use border-box so that it doesn’t screw the box model,
      which means it impacts colWidth and max-width */
   box-sizing: border-box;
+}
+
+:root:not(:--scroll-view) body {
   padding: var(--RS__pageGutter) 0 !important;
 }
 

css/src/modules/ReadiumCSS-pagination.css

@@ -80,6 +80,9 @@ body {
      Drawback: we have to use border-box so that it doesn’t screw the box model,
      which means it impacts colWidth and max-width */
   box-sizing: border-box;
+}
+
+:root:not(:--scroll-view) body {
   padding: 0 var(--RS__pageGutter) !important;
 }
 

docs/CSS28-migration_guide.md

@@ -258,4 +258,20 @@ As of version `2.0.0-beta.23`, ReadiumCSS provides flags as a way to opt-in to a
 - `--RS__experimentalHeaderFiltering: readium-experimentalHeaderFiltering-on`: attempts to filter out paragraphs that are implicitly headings or part of headers
 - `--RS__experimentalZoom: readium-experimentalZoom-on`: attemps to filter out elements that are sized using viewport units and should not be scaled directly
 
-These flags are expected to be found on `:root`.
+These flags are expected to be found on `:root`.
+
+## Fonts are no longer distributed in the package
+
+As of version `2.0.0` (stable), ReadiumCSS no longer distributes fonts and their `font-face` rules. You will need to load them yourself.
+
+**This is a breaking change.**
+
+This means AccessibleDfa, iA Writer Duospace, and the Android FXL fonts patch are no longer included, nor are their `font-face` rules.
+
+## PageGutter no longer applies in scroll view
+
+As of version `2.0.0` (stable), the `--RS__pageGutter` property no longer applies in scroll view.
+
+**This is a breaking change.**
+
+If you need to apply padding to the scroll view, you can use the `--RS__scrollPadding` properties instead. This can be useful to get around safe area insets, or to add whitespace so that contents are not hidden behind UI elements.

docs/ReadiumCSS_docs.epub

@@ -310,6 +310,26 @@ const backgroundColor = defaultColors.RS__backgroundColor;</code></pre>
         <li><code>--RS__experimentalZoom: readium-experimentalZoom-on</code>: attemps to filter out elements that are sized using viewport units and should not be scaled directly</li>
       </ul>
     </section>
+
+    <section id="fonts-removed-from-package" class="level2">
+      <h2 id="sigil_toc_id_223">Fonts are no longer distributed in the package</h2>
+
+      <p>As of version <code>2.0.0</code> (stable), ReadiumCSS no longer distributes fonts and their <code>font-face</code> rules. You will need to load them yourself.</p>
+
+      <p><strong>This is a breaking change.</strong></p>
+
+      <p>This means AccessibleDfa, iA Writer Duospace, and the Android FXL fonts patch are no longer included, nor are their <code>font-face</code> rules.</p>
+    </section>
+
+    <section id="pagegutter-removed-from-scroll-view" class="level2">
+      <h2 id="sigil_toc_id_224">PageGutter no longer applies in scroll view</h2>
+
+      <p>As of version <code>2.0.0</code> (stable), the <code>--RS__pageGutter</code> property no longer applies in scroll view.</p>
+
+      <p><strong>This is a breaking change.</strong></p>
+
+      <p>If you need to apply padding to the scroll view, you can use the <code>--RS__scrollPadding</code> properties instead. This can be useful to get around safe area insets, or to add whitespace so that contents are not hidden behind UI elements.</p>
+    </section>
   </section>
 </body>
 </html>

docs/ReadiumCSS_docs/OEBPS/Text/Section-028.xhtml

@@ -773,6 +773,12 @@
         <li>
           <a href="../Text/Section-028.xhtml#sigil_toc_id_219">Experimental Features Flags</a>
         </li>
+        <li>
+          <a href="../Text/Section-028.xhtml#sigil_toc_id_223">Fonts are no longer distributed in the package</a>
+        </li>
+        <li>
+          <a href="../Text/Section-028.xhtml#sigil_toc_id_224">PageGutter no longer applies in scroll view</a>
+        </li>
       </ol>
       </li>
     </ol>