Skip to content
This repository was archived by the owner on May 6, 2025. It is now read-only.
This repository was archived by the owner on May 6, 2025. It is now read-only.

API inconsistency, manifest absolute file path: '/' character prefix when no "root" content folder (because of Package->BasePath()) #91

Open
@danielweck

Description

@danielweck

Manifest Items absolute paths are returned with prefix '/' when the EPUB OPF is not located within the typical subfolder (OEBPS, EPUB, etc.)
So, instead of say: "OEBPS/html/chapter1.xhtml", it returns "/html/chapter1.xhtml" !!
(note the '/' root path discrepancy)

This is due to Package->BasePath() returning "/" in one case, but "OEBPS/" instead of "/OEBPS/" in the other case.
https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/package.h#L124
https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/package.cpp#L111

See related Media Overlays fix:
4ad3e73

See related FontObfuscation fix:
1a43b1e

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions