-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Labels
rubyIssues related to our Ruby SDKIssues related to our Ruby SDK
Description
The Ruby SDK requires the Rack HTTP web server to be installed. There are two problems here: First, rack
isn't specified in the Gemfile. Second, rack
is required even if you're just using readme/webhook
which doesn't directly depend on Rack.
I think the second issue is because when you require readme/webhook
, it loads lib/readme/webhook.rb
. The first line of that file is:
require 'readme/metrics' |
This loads the entire readme/metrics
package, and that needs Rack. But I think we have to do it this way so that we can "monkeypatch" the Readme
module.
Two solutions that I think will help with all this:
- Create some other overarching file that defines the
Readme
module, so thatreadme/webhook
never needs to loadreadme/metrics
. (My Ruby is pretty rusty so I'm not sure whether this even makes sense, but I think there's probably something we can do with an extra layer of indirection…) - Add
rack
to the Gemfile.
Metadata
Metadata
Assignees
Labels
rubyIssues related to our Ruby SDKIssues related to our Ruby SDK