-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Open
Labels
ImprovementMinor improvement to codeMinor improvement to codeNeeded: design decisionA core team decision is requiredA core team decision is required
Description
We are using Python's fnmatch to match the files and filter (whether trigger or not the build). This implementation has a few limitations:
- we cannot match multiple type of files/paths (
mymodule/*.pyanddocs/*.rst - it doesn't support
**for nested directories (**/.rst) - ... maybe other ones
I think a basic use case we will want to support here would be: .readthedocs.yaml & docs/* & requirements/docs.txt. Currently, we cannot do that and we need to create three different rules for that.
I'm creating this issue to think about how to model this. We may want to make the field a TextField and accept one rule per line, as we've done in other places. I'd say that's probably the easiest way to implement and to communicate to the user as well. This solves 1) but it doesn't solve 2)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
ImprovementMinor improvement to codeMinor improvement to codeNeeded: design decisionA core team decision is requiredA core team decision is required
Type
Projects
Status
Planned