fix: json_build_object created with empty exprs

Fix a bug made in https://gerrit.readyset.name/c/readyset/+/8868
Adding tests as well.

Fixes: REA-4369
Change-Id: I96cf80fda00423b45837ce5e238377c2dd2a0f34
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/8911
Tested-by: Buildkite CI
Reviewed-by: Vassili Zarouba <[email protected]>

Author: MohamedAbdeen-rs

dataflow-expression/src/lower.rs

@@ -289,7 +289,7 @@ impl BuiltinFunction {
 
                 (
                     Self::JsonBuildObject {
-                        args: args.by_ref().collect(),
+                        args: exprs,
                         allow_duplicate_keys: true,
                     },
                     DfType::Json,
@@ -304,7 +304,7 @@ impl BuiltinFunction {
 
                 (
                     Self::JsonBuildObject {
-                        args: args.by_ref().collect(),
+                        args: exprs,
                         allow_duplicate_keys: false,
                     },
                     DfType::Json,

logictests/json_object.test

@@ -20,3 +20,20 @@ SELECT json_object(a, b, c, d) FROM t1;
 # Requires even number of arguments
 statement error
 SELECT json_object(a, b, c) FROM t1;
+
+query T
+SELECT json_build_object(a, b, c, d) FROM t1;
+----
+{"abc":3.14,"1":1}
+{"xyz":2.71,"2":0}
+
+statement ok
+CREATE TABLE t2 (a TEXT, b DOUBLE, c TEXT, d BOOL);
+
+statement ok
+INSERT INTO t2 VALUES ("abc", 3.14, "abc", true);
+
+query T
+SELECT jsonb_build_object(a, b, c, d) FROM t2;
+----
+{"abc":1}